Change sharing note default text to a title#18735
Change sharing note default text to a title#18735ChristophWurst wants to merge 1 commit intomasterfrom
Conversation
ChristophWurst
added
enhancement
design
| SHARE_TYPE_ROOM: OC.Share.SHARE_TYPE_ROOM, | ||
| }, | ||
|
|
||
| shareHasNote: !!this.share.note |
There was a problem hiding this comment.
This will cause issues with the virtual dom when adding new shares.
Data is not 100% reset between vdom reuses :)
There was a problem hiding this comment.
A watcher on the share prop?
There was a problem hiding this comment.
Computed.
Or leave it like it was before and just select the whole content when focusing the input to allow easy overwrite of the content?
There was a problem hiding this comment.
Or leave it like it was before and just select the whole content when focusing the input to allow easy overwrite of the content?
I'm just a dev but as far as I know we should avoid this pattern where we have inline labels that vanish once you have input. With the title you can see the description of the input field also later on. But not my call.
Computed.
I don't know how to do this. Implemented it with a watcher now because that seems to work just fine. Feel free to push your enhancements if you have a better solution :)
There was a problem hiding this comment.
Also, I don't really like having dedicated methods like those laying around. Automatic processing is less error prone than manually updating a static variable imo :)
There was a problem hiding this comment.
What's wrong with the good old placeholder attribute in a textbox element?
There was a problem hiding this comment.
You lose the description as soon as you enter your text. So, if you go back later, or just go up on a long form, you don't see the description of the input anymore.
https://www.nngroup.com/articles/form-design-placeholders/
https://joshuawinn.com/ux-input-placeholders-are-not-labels/
Anyway, leaving that decision to a11y experts @nextcloud/accessibility
@skjnldsv if you have a simpler approach that also works please push it.
There was a problem hiding this comment.
You lose the description as soon as you enter your text. So, if you go back later, or just go up on a long form, you don't see the description of the input anymore.
Since there's still the heading, I find it acceptable in this case to lose the description what to do with a text box.
There are way worse cases for example in user_saml
|
master is NC19 now. |
|
/backport to stable18 |
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
fix/sharing-note-title
branch
from
8dbb5e3 to
0a406ae
Compare
4 participants
Fixes #18451