Check for compatible apps from the appstore fails#12358
Conversation
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
added
3. to review
|
|
||
| $.ajax({ | ||
| url: OC.linkToOCS('apps/updatenotification/api/v1/applist', 2) + this.newVersionString, | ||
| url: OC.linkToOCS('apps/updatenotification/api/v1/applist', 2) + this.newVersion, |
There was a problem hiding this comment.
Error 1: We asked for updates on applist/Nextcloud 15.0.0 beta1 => 404
There was a problem hiding this comment.
Error 3: Even if it gives back a 404 it should not say "Yes all fine", but rather "It can't be detected"
There was a problem hiding this comment.
Well that is exactly what it does now, after error2 was solved:
Could not connect to the appstore or the appstore returned no updates at all. Search manually for updates or make sure your server has access to the internet and can connect to the appstore.
| } | ||
|
|
||
| if (this.appstoreFailed) { | ||
| if (this.appStoreFailed) { |
There was a problem hiding this comment.
Error 2: We checked an undefined argument because of the casing mismatch
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
left a comment
MorrisJobke
left a comment
There was a problem hiding this comment.
Tested and works 👍
I added one CSS rule to give the app list a little more margin to the bottom (same as the <p> element have on that page).
Before and after:
MorrisJobke
added
4. to release
|
👍 since I cant approve my own PR although it has commits from you |
|
@nickvergessen Failing unit tests 🙈 |
Signed-off-by: Joas Schilling <coding@schilljs.com>
3 participants
based on #12354