showDirectoryWhenDeletionCompleted set to false?

[tobiasKaminsky]

• Tests written, or not not needed

[tobiasKaminsky]

@alperozturk96 I am not sure why this boolean is needed at all?

old behaviour

• have multible images in a folder
• click on one, to open slide show
• delete one
  --> folder listing is shown

now:

• have multible images in a folder
• click on one, to open slide show
• delete one
  --> another image is shown

I also tested if last image is deleted, then the empty directory is shown

[alperozturk96]

@alperozturk96 I am not sure why this boolean is needed at all?

old behaviour

• have multible images in a folder
• click on one, to open slide show
• delete one
  --> folder listing is shown

now:

• have multible images in a folder
• click on one, to open slide show
• delete one
  --> another image is shown

I also tested if last image is deleted, then the empty directory is shown

PreviewImageActivity extends from FileActivity, so the delete logic in RemoveFilesDialogFragment was not applied when deleting an image from the preview. I have addressed in this PR (#14498).

I thought this was not the expected behavior. Since the user is in a folder rather than a gallery, I would expect the flow to return directly to the file list after deleting an image, rather than continuing to view other images in the folder.

If the expected behavior is to continue viewing other images, you can remove the showDirectoryWhenDeletionCompleted() function and the showDirectoryWhenDeletionCompleted boolean variable.

[tobiasKaminsky]

It is the expected (and previous behaviour), thus I will remove it.
Thanks for the confirmation 👍

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14646.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[github-actions]

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

[alperozturk96]

/backport to stable-3.31