Skip to content

BugFix - E2EE Delete File#14498

Merged
tobiasKaminsky merged 1 commit intomasterfrom
bugfix/e2ee-delete-file
Feb 10, 2025
Merged

BugFix - E2EE Delete File#14498
tobiasKaminsky merged 1 commit intomasterfrom
bugfix/e2ee-delete-file

Conversation

@alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Feb 5, 2025

  • Tests written, or not not needed

Problem

If the user tries to preview an image from the directory, the file cannot be deleted.

How to test?

  1. Create an encrypted folder
  2. Add images into the encrypted folder
  3. Open image from folder
  4. Try to delete image from top right more menu

Signed-off-by: alperozturk <alper_ozturk@proton.me>
@github-actions
Copy link

github-actions bot commented Feb 5, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14498.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link

github-actions bot commented Feb 5, 2025

Codacy

Lint

TypemasterPR
Warnings5556
Errors33

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness5757
Dodgy code294294
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness77
Performance5353
Security1818
Total503503

Lint increased!

@github-actions
Copy link

github-actions bot commented Feb 5, 2025

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@alperozturk96 alperozturk96 added this to the Nextcloud App 3.31.0 milestone Feb 10, 2025
@alperozturk96
Copy link
Collaborator Author

/backport to stable-3.31

@tobiasKaminsky tobiasKaminsky merged commit 174b8fc into master Feb 10, 2025
21 of 23 checks passed
@tobiasKaminsky tobiasKaminsky deleted the bugfix/e2ee-delete-file branch February 10, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants