Revert "Sets IsComposable=true for workbook* bound types"#590
Revert "Sets IsComposable=true for workbook* bound types"#590andrueastman merged 1 commit intomasterfrom
IsComposable=true for workbook* bound types"#590Conversation
This reverts commit 580c195.
baywet
left a comment
There was a problem hiding this comment.
If I'm not mistaken, the before size is around 70MB. This would a 50% + increase. The impact on the SDKs is probably around the same.
Before we revert the change entirely, do we have an idea of what's causing the over expansion?
Customers have been requesting support for Excel endpoints for the longest time, and we're very close to enabling them.
If we have time to do so, I'd prefer waiting to merge that PR and looking into the details.
Maybe there's another contains target is composable we can switch to solve that.
But let's make sure we time box the investigation.
|
The size of the resulting SDKs worries me. It's not necessarily related to this change, but if it's something that explodes our SDK size but provide very niche value, I'm proposing we think deeper about our generation logic and identify creative ways to deliver the value in some alternative ways. This might be a GREAT case of self-serve docs? |
|
The original doc has a size of appr. 28 MBs, whereas the new one has an appr. size of 238 MBs. The |
|
@baywet I think we should probably think about going ahead with reverting this PR for now given the size increases. As an aside we can probably look into the NavigationType annotation which may not necessarily apply to functions/actions. |
|
@andrueastman sure, let's go ahead with a revert to unblock weekly generations. |
Temporarily Reverts #585
The generation pipeline isn't able to push some yamls because of the size exceeding 100MB so we would need to resolve #184 first to enable git LFS if we are to go forward.
#585 (comment)
cc @baywet @irvinesunday