Skip to content

Sets IsComposable=true for workbook* bound types#585

Merged
irvinesunday merged 1 commit intomasterfrom
is/set-composable-fxns
Mar 6, 2024
Merged

Sets IsComposable=true for workbook* bound types#585
irvinesunday merged 1 commit intomasterfrom
is/set-composable-fxns

Conversation

@irvinesunday
Copy link
Copy Markdown
Contributor

Fixes #582

  • There are no tests for this PR because to see the output the default variables values: remove-capability-annotations and add-innererror-description in the XSL file will have to be changed to False and True respectively.
  • There seems to be a typo in the naming of bindparameter instead of bindingparameter in the CSDL for the respective APIs been updated. These affects both actions and functions of these APIs. The mistyped bindparameter is used in the XSL script so that a match is possible. When these have been resolved upstream, we shall make the necessary changes here as well. @marabooy are you able to help surface this to the relevant API owner(s)?
  • We are specifically setting IsComposable=true for Kiota-based OpenApi generation. This is because the aftermath of this is an increase in the number of paths, which may potentially affect the PowerShell SDK. See below diffs for the expected change in the number of paths after this change goes out:

@irvinesunday irvinesunday self-assigned this Mar 5, 2024
@irvinesunday irvinesunday requested a review from a team as a code owner March 5, 2024 22:19
@irvinesunday irvinesunday merged commit 580c195 into master Mar 6, 2024
@irvinesunday irvinesunday deleted the is/set-composable-fxns branch March 6, 2024 11:20
@andrueastman
Copy link
Copy Markdown
Contributor

@baywet @irvinesunday

I think we may have to revert this PR temporarily to deal with some infrastructure issues. The generation pipeline isn't able to push some yamls because of the size exceeding 100MB so we would need to resolve #184 first to enable git LFS if we are to go forward.

Lemme know your thoughts here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

functions range bound to workbookRangeview, workbookNamedItem, etc...

3 participants