fix search and replace all

[tofpie]

Fixes #57
Fixes #58

[tofpie]

Probably not the most efficient fix, but, you get the idea!

[lhecker]

That's indeed not exactly something I'd want to merge. The fact that this fixes the issue however means that there's a bug somewhere here, I believe:

edit/src/icu.rs

Lines 384 to 406 in c13b8ab

	let index_contained = index_contained as usize;
	let native_index = native_index as usize;
	let double_cache = double_cache_from_utext(ut);
	let dirty = ut.a != tb.generation() as i64;
	if dirty {
	// The text buffer contents have changed.
	// Invalidate both caches so that future calls don't mistakenly use them
	// when they enter the for loop in the else branch below (`dirty == false`).
	double_cache.cache[0].utf16_len = 0;
	double_cache.cache[1].utf16_len = 0;
	double_cache.cache[0].utf8_range = 0..0;
	double_cache.cache[1].utf8_range = 0..0;
	ut.a = tb.generation() as i64;
	} else {
	// Check if one of the caches already contains the requested range.
	for (i, cache) in double_cache.cache.iter_mut().enumerate() {
	if cache.utf8_range.contains(&index_contained) {
	double_cache.mru = i != 0;
	return Some(cache);
	}
	}
	}

Or it's because the ICU Regex instance doesn't get invalidated? #123 may have a better approach for this overall, but I'm not entirely sure yet what it is, given that #123 isn't correct yet either.

[lhecker]

(I'll be blocking some PRs for "Request changes", so I can keep track of where I left notes on and which ones I still need to review.)

[lhecker]

I had time to debug this and fixed it over in #258. Closing this PR. 🙂