Merged
Conversation
DHowett
reviewed
May 24, 2025
| unsafe { (f.uregex_setUText)(self.0, text.0 as *const _ as *mut _, &mut status) }; | ||
| // `uregex_setUText` resets the regex to the start of the text. | ||
| // Because of this, we must also call `uregex_reset64`. | ||
| unsafe { (f.uregex_reset64)(self.0, offset as i64, &mut status) }; |
Member
There was a problem hiding this comment.
Does setting the offset to the start of the match cause us to deadlock if you Find "a" replace with "a"? Do we need somehow to skip the matched section?
Member
Author
There was a problem hiding this comment.
In this case the caller specifies the "current offset" which is past the replaced range.
DHowett
approved these changes
May 25, 2025
diabloproject
pushed a commit
to diabloproject/edit
that referenced
this pull request
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #57
Closes #58