Fix Find & Replace with empty replacements#457
Merged
Conversation
Contributor
|
One thing I noticed with this approach is that some of the callers of this function check if it's empty before calling it anyway. So most of the behaviour is the same outside of the find & replace use case. edit/src/bin/edit/draw_menubar.rs Line 81 in f0cb63b Edit: |
Member
Author
|
Oh, thanks for noticing this. |
Member
Author
|
On second thought, coincidentally we don't need to fix this, because I already rewrote clipboard handling where it checks for empty clipboard contents: #405 |
DHowett
approved these changes
Jun 10, 2025
Lou32Verbose
pushed a commit
to Lou32Verbose/edit
that referenced
this pull request
Jan 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #439