Conversation
DHowett
reviewed
Jun 3, 2025
| let clipboard = self.clipboard_mut(); | ||
| clipboard.write(paste); | ||
| clipboard.mark_as_synchronized(); | ||
| input_keyboard = Some(kbmod::CTRL | vk::V); |
Member
There was a problem hiding this comment.
Hmmm not my favorite part of this PR!
Member
Author
There was a problem hiding this comment.
You can think of this as an action placeholder. If we add action types in the future this would read something like:
input_action = Some(Paste);
DHowett
approved these changes
Jun 10, 2025
DHowett
approved these changes
Jun 10, 2025
Lou32Verbose
pushed a commit
to Lou32Verbose/edit
that referenced
this pull request
Jan 11, 2026
* Make each paste its own undo step. * Add a `Paste` input type, allowing us to... * Fill the internal clipboard with bracketed paste contents. * Abstract away clipboard handling into its own struct, so we can move the cut/copy/paste logic into `TextBuffer`, allowing us to... * Implement smart line-wise copy/paste via Ctrl+C/Ctrl+V. Closes microsoft#286 Closes microsoft#305
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pasteinput type, allowing us to...the cut/copy/paste logic into
TextBuffer, allowing us to...Closes #286
Closes #305