Move Go to Line/Column higher in menu#264
Closed
ankddev wants to merge 1 commit intomicrosoft:mainfrom
Closed
Conversation
Signed-off-by: ANKDDEV <andrekabatareika@gmail.com>
Member
|
FWIW I knew about these issues with the PR, but I didn't want to go back and forth with the contributor about these things, so I was meaning to fix it today. Go to Line for instance doesn't belong into that menu at all. It changes the viewport of the editor and thus belongs into the "View" menu. It also needs to be removed as a menu item if there's no open file. I'm grateful that you opened the PR, but I'll close it in favor of mine (#267), which addresses other issues as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #261.
Description
Move
Go to Line/Columnhigher in menu. I think thatClose editorandExitshould be last options on menu; other editors do same.Screenshots
(In Russian locale)
