Mac: Update MoveAndOverwriteFile to use native API#344
Merged
wilbaker merged 1 commit intomicrosoft:masterfrom Oct 4, 2018
Merged
Mac: Update MoveAndOverwriteFile to use native API#344wilbaker merged 1 commit intomicrosoft:masterfrom
wilbaker merged 1 commit intomicrosoft:masterfrom
Conversation
kewillford
approved these changes
Oct 4, 2018
| if (Rename(sourceFileName, destinationFilename) != 0) | ||
| { | ||
| File.Delete(destinationFilename); | ||
| NativeMethods.ThrowLastWin32Exception($"Failed to renname {sourceFileName} to {destinationFilename}"); |
Member
There was a problem hiding this comment.
A little weird throwing a Win32Exception from the Mac code but in searching it looks like we are already dependent on that exception.
Contributor
There was a problem hiding this comment.
Yep it is weird, but this is what the .NET Core APIs chose to do as well. We just need to translate "Win32Exception" to "NativeException".
Member
Author
There was a problem hiding this comment.
Yep here is an example:
.NET Core's I/O methods will translate native error codes into a more appropriate exception when possible (e.g. IOException), but in our code we consistently throw Win32Exceptions for all failed native calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #342.
The initial
MoveAndOverwriteFilecould result in a missing file (ifFile.Deletesucceeded andFile.Movefailed).Switch to the atomic
renamefunction.