Mac: Failed : GVFS.FunctionalTests.Tests.GitCommands.CheckoutTests.EditFileReadFileAndCheckoutConflict

[wilbaker]

2018-10-04T19:33:02.7101730Z 1) Failed : GVFS.FunctionalTests.Tests.GitCommands.CheckoutTests.EditFileReadFileAndCheckoutConflict()
2018-10-04T19:33:02.7102150Z   Path does NOT exist: /GVFS.FT/test/09d7a52d48de4899b9a7/.gvfs/databases/ModifiedPaths.dat
2018-10-04T19:33:02.7102360Z   Expected: True
2018-10-04T19:33:02.7102470Z   But was:  False
2018-10-04T19:33:02.7102620Z    at GVFS.Tests.Should.ValueShouldExtensions.ShouldEqual[T](T actualValue, T expectedValue, String message) in /Users/vsts/agent/2.140.2/work/1/s/GVFS/GVFS.Tests/Should/ValueShouldExtensions.cs:line 34
2018-10-04T19:33:02.7102940Z    at GVFS.FunctionalTests.Should.FileSystemShouldExtensions.FileAdapter..ctor(String path, FileSystemRunner runner) in /Users/vsts/agent/2.140.2/work/1/s/GVFS/GVFS.FunctionalTests/Should/FileSystemShouldExtensions.cs:line 71
2018-10-04T19:33:02.7103210Z    at GVFS.FunctionalTests.Should.FileSystemShouldExtensions.ShouldBeAFile(String path, FileSystemRunner runner) in /Users/vsts/agent/2.140.2/work/1/s/GVFS/GVFS.FunctionalTests/Should/FileSystemShouldExtensions.cs:line 36
2018-10-04T19:33:02.7103460Z    at GVFS.FunctionalTests.Tools.GVFSHelpers.ModifiedPathsShouldNotContain(FileSystemRunner fileSystem, String dotGVFSRoot, String[] gitPaths) in /Users/vsts/agent/2.140.2/work/1/s/GVFS/GVFS.FunctionalTests/Tools/GVFSHelpers.cs:line 127
2018-10-04T19:33:02.7104100Z    at GVFS.FunctionalTests.Tests.GitCommands.CheckoutTests.EditFileReadFileAndCheckoutConflict() in /Users/vsts/agent/2.140.2/work/1/s/GVFS/GVFS.FunctionalTests/Tests/GitCommands/CheckoutTests.cs:line 332

This could be because MoveAndOverwriteFile in GVFS.Platform.Mac is currently implemented as delete + rename:

        public void MoveAndOverwriteFile(string sourceFileName, string destinationFilename)
        {
            // TODO(Mac): Use native API
            if (File.Exists(destinationFilename))
            {
                File.Delete(destinationFilename);
            }

            File.Move(sourceFileName, destinationFilename);
        }