Enable setting and removing fixed position via remote admin#675
Merged
ianmcorvidae merged 2 commits intomeshtastic:masterfrom Sep 19, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #675 +/- ##
==========================================
- Coverage 60.94% 60.91% -0.04%
==========================================
Files 24 24
Lines 3690 3689 -1
==========================================
- Hits 2249 2247 -2
- Misses 1441 1442 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
|
Looks good! Thanks for picking this up, I hadn't gotten to it yet. I don't think we need to worry about older firmware versions. They'll reject any updates that get sent by this, but if someone hasn't updated they're probably aware of that constraint anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on recent firmware change to allow remote admin position config.
Question: do we need to handle old firmware versions with this change?