Skip to content

Creister/check ishidden changed #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marlimox merged 2 commits into from
Dec 17, 2018
Merged

Creister/check ishidden changed #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e28dd5
Test to ensure duplicate calls to setRowHidden are handled
Dec 14, 2018
94668d6
Check that cell isHidden property has changed before setting
Dec 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/AloeStackView/AloeStackView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ open class AloeStackView: UIScrollView {
///
/// If `animated` is `true`, the change is animated.
open func setRowHidden(_ row: UIView, isHidden: Bool, animated: Bool = false) {
guard let cell = row.superview as? StackViewCell else { return }
guard let cell = row.superview as? StackViewCell, cell.isHidden != isHidden else { return }

if animated {
UIView.animate(withDuration: 0.3) {
Expand Down
12 changes: 12 additions & 0 deletions Tests/AloeStackViewTests/AloeStackViewTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,16 @@ final class AloeStackViewTests: XCTestCase {
func test() {
}

func testSetRowHiddenDuplicateCalls() {
let stackView = AloeStackView()
let row = UIView()
stackView.addRow(row)

stackView.setRowHidden(row, isHidden: true, animated: true)
stackView.setRowHidden(row, isHidden: true, animated: true)
stackView.setRowHidden(row, isHidden: false, animated: true)

XCTAssertFalse(stackView.isRowHidden(row))
}

}