Creister/check ishidden changed#27
Merged
marlimox merged 2 commits intomarlimox:masterfrom Dec 17, 2018
Merged
Conversation
Currently this test will fail, as hiding row with animation multiple times syncronously will cause unhiding to fail
marlimox
approved these changes
Dec 15, 2018
| /// If `animated` is `true`, the change is animated. | ||
| open func setRowHidden(_ row: UIView, isHidden: Bool, animated: Bool = false) { | ||
| guard let cell = row.superview as? StackViewCell else { return } | ||
| guard cell.isHidden != isHidden else { return } |
Owner
There was a problem hiding this comment.
Style: put this extra condition in the first guard statement after a comma.
This fixes failing test testSetRowHiddenDuplicateCalls
creister
force-pushed
the
creister/check-ishidden-changed
branch
from
8a66282 to
94668d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, we found that multiple calls to hideRow (with
true) can cause unhiding to fail, this is due toisHiddenhaving to be called inside the animation block. This PR simply checks that isHidden is changing to avoid multiple calls causing issues.