-
Notifications
You must be signed in to change notification settings - Fork 3
chore: Update grid API schemas from webdev #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| type: object | ||
| required: | ||
| - pixKey | ||
| - pixKeyType | ||
| - taxId | ||
| properties: | ||
| pixKey: | ||
| type: string | ||
| description: The PIX key of the bank | ||
| pixKeyType: | ||
| type: string | ||
| description: The type of PIX key of the bank | ||
| taxId: | ||
| type: string | ||
| description: The tax ID of the bank account |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| type: object | ||
| required: | ||
| - fullName | ||
| properties: | ||
| fullName: | ||
| type: string | ||
| description: The full name of the beneficiary | ||
| birthDate: | ||
| type: string | ||
| description: The birth date of the beneficiary | ||
| nationality: | ||
| type: string | ||
| description: The nationality of the beneficiary | ||
| email: | ||
| type: string | ||
| description: The email of the beneficiary | ||
| phoneNumber: | ||
| type: string | ||
| description: The phone number of the beneficiary | ||
| registrationNumber: | ||
| type: string | ||
| description: The registration number of the beneficiary | ||
| countryOfResidence: | ||
| type: string | ||
| description: The country of residence of the beneficiary | ||
| address: | ||
| type: object | ||
| required: | ||
| - country | ||
| - line1 | ||
| - postalCode | ||
| properties: | ||
| line1: | ||
| type: string | ||
| description: Address line 1 | ||
| postalCode: | ||
| type: string | ||
| description: Postal code | ||
| country: | ||
| type: string | ||
| description: Country code | ||
| line2: | ||
| type: string | ||
| description: Address line 2 | ||
| city: | ||
| type: string | ||
| description: City | ||
| state: | ||
| type: string | ||
| description: State or province |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| type: object | ||
| required: | ||
| - iban | ||
| properties: | ||
| iban: | ||
| type: string | ||
| description: The IBAN of the bank | ||
| swiftBic: | ||
| type: string | ||
| description: The SWIFT BIC of the bank |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| type: object | ||
| required: | ||
| - fullName | ||
| properties: | ||
| fullName: | ||
| type: string | ||
| description: The full name of the beneficiary | ||
| birthDate: | ||
| type: string | ||
| description: The birth date of the beneficiary | ||
| nationality: | ||
| type: string | ||
| description: The nationality of the beneficiary | ||
| email: | ||
| type: string | ||
| description: The email of the beneficiary | ||
| phoneNumber: | ||
| type: string | ||
| description: The phone number of the beneficiary | ||
| registrationNumber: | ||
| type: string | ||
| description: The registration number of the beneficiary | ||
| countryOfResidence: | ||
| type: string | ||
| description: The country of residence of the beneficiary | ||
| address: | ||
| type: object | ||
| required: | ||
| - country | ||
| - line1 | ||
| - postalCode | ||
| properties: | ||
| line1: | ||
| type: string | ||
| description: Address line 1 | ||
| postalCode: | ||
| type: string | ||
| description: Postal code | ||
| country: | ||
| type: string | ||
| description: Country code | ||
| line2: | ||
| type: string | ||
| description: Address line 2 | ||
| city: | ||
| type: string | ||
| description: City | ||
| state: | ||
| type: string | ||
| description: State or province |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,11 @@ | ||
| type: object | ||
| required: | ||
| - sortCode | ||
| - accountNumber | ||
| - accountType | ||
| - sortCode | ||
| - accountNumber | ||
| properties: | ||
| accountType: | ||
| type: string | ||
| enum: | ||
| - GBP_ACCOUNT | ||
| sortCode: | ||
| type: string | ||
| description: UK bank sort code (6 digits, may include hyphens) | ||
| example: '20-00-00' | ||
| pattern: '^[0-9]{2}-?[0-9]{2}-?[0-9]{2}$' | ||
| description: The sort code of the bank | ||
| accountNumber: | ||
| type: string | ||
| description: UK bank account number (8 digits) | ||
| example: '12345678' | ||
| minLength: 8 | ||
| maxLength: 8 | ||
| pattern: ^[0-9]{8}$ | ||
| description: The account number of the bank | ||
|
Comment on lines
1
to
+11
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed validation patterns that enforced UK banking format requirements (sortCode: Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/components/schemas/common/GbpAccountInfo.yaml
Line: 1:11
Comment:
Removed validation patterns that enforced UK banking format requirements (sortCode: `^[0-9]{2}-?[0-9]{2}-?[0-9]{2}$`, accountNumber: `^[0-9]{8}$` with length 8). Check if validation moved elsewhere or if loosened constraints are intentional.
How can I resolve this? If you propose a fix, please make it concise. |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| type: object | ||
| required: | ||
| - fullName | ||
| properties: | ||
| fullName: | ||
| type: string | ||
| description: The full name of the beneficiary | ||
| birthDate: | ||
| type: string | ||
| description: The birth date of the beneficiary | ||
| nationality: | ||
| type: string | ||
| description: The nationality of the beneficiary | ||
| email: | ||
| type: string | ||
| description: The email of the beneficiary | ||
| phoneNumber: | ||
| type: string | ||
| description: The phone number of the beneficiary | ||
| registrationNumber: | ||
| type: string | ||
| description: The registration number of the beneficiary | ||
| countryOfResidence: | ||
| type: string | ||
| description: The country of residence of the beneficiary | ||
| address: | ||
| type: object | ||
| required: | ||
| - country | ||
| - line1 | ||
| - postalCode | ||
| properties: | ||
| line1: | ||
| type: string | ||
| description: Address line 1 | ||
| postalCode: | ||
| type: string | ||
| description: Postal code | ||
| country: | ||
| type: string | ||
| description: Country code | ||
| line2: | ||
| type: string | ||
| description: Address line 2 | ||
| city: | ||
| type: string | ||
| description: City | ||
| state: | ||
| type: string | ||
| description: State or province |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| type: object | ||
| required: | ||
| - bankName | ||
| - accountNumber | ||
| properties: | ||
| bankName: | ||
| type: string | ||
| description: The bank name of the bank | ||
| accountNumber: | ||
| type: string | ||
| description: The account number of the bank |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| type: object | ||
| required: | ||
| - fullName | ||
| properties: | ||
| fullName: | ||
| type: string | ||
| description: The full name of the beneficiary | ||
| birthDate: | ||
| type: string | ||
| description: The birth date of the beneficiary | ||
| nationality: | ||
| type: string | ||
| description: The nationality of the beneficiary | ||
| email: | ||
| type: string | ||
| description: The email of the beneficiary | ||
| phoneNumber: | ||
| type: string | ||
| description: The phone number of the beneficiary | ||
| registrationNumber: | ||
| type: string | ||
| description: The registration number of the beneficiary | ||
| countryOfResidence: | ||
| type: string | ||
| description: The country of residence of the beneficiary | ||
| address: | ||
| type: object | ||
| required: | ||
| - country | ||
| - line1 | ||
| - postalCode | ||
| properties: | ||
| line1: | ||
| type: string | ||
| description: Address line 1 | ||
| postalCode: | ||
| type: string | ||
| description: Postal code | ||
| country: | ||
| type: string | ||
| description: Country code | ||
| line2: | ||
| type: string | ||
| description: Address line 2 | ||
| city: | ||
| type: string | ||
| description: City | ||
| state: | ||
| type: string | ||
| description: State or province |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| type: object | ||
| required: | ||
| - sortCode | ||
| - accountNumber | ||
| properties: | ||
| sortCode: | ||
| type: string | ||
| description: The sort code of the bank | ||
| accountNumber: | ||
| type: string | ||
| description: The account number of the bank |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| type: object | ||
| required: | ||
| - fullName | ||
| properties: | ||
| fullName: | ||
| type: string | ||
| description: The full name of the beneficiary | ||
| birthDate: | ||
| type: string | ||
| description: The birth date of the beneficiary | ||
| nationality: | ||
| type: string | ||
| description: The nationality of the beneficiary | ||
| email: | ||
| type: string | ||
| description: The email of the beneficiary | ||
| phoneNumber: | ||
| type: string | ||
| description: The phone number of the beneficiary | ||
| registrationNumber: | ||
| type: string | ||
| description: The registration number of the beneficiary | ||
| countryOfResidence: | ||
| type: string | ||
| description: The country of residence of the beneficiary | ||
| address: | ||
| type: object | ||
| required: | ||
| - country | ||
| - line1 | ||
| - postalCode | ||
| properties: | ||
| line1: | ||
| type: string | ||
| description: Address line 1 | ||
| postalCode: | ||
| type: string | ||
| description: Postal code | ||
| country: | ||
| type: string | ||
| description: Country code | ||
| line2: | ||
| type: string | ||
| description: Address line 2 | ||
| city: | ||
| type: string | ||
| description: City | ||
| state: | ||
| type: string | ||
| description: State or province |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| type: object | ||
| required: | ||
| - vpa | ||
| properties: | ||
| vpa: | ||
| type: string | ||
| description: The VPA of the bank |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| type: object | ||
| required: | ||
| - fullName | ||
| properties: | ||
| fullName: | ||
| type: string | ||
| description: The full name of the beneficiary | ||
| birthDate: | ||
| type: string | ||
| description: The birth date of the beneficiary | ||
| nationality: | ||
| type: string | ||
| description: The nationality of the beneficiary | ||
| email: | ||
| type: string | ||
| description: The email of the beneficiary | ||
| phoneNumber: | ||
| type: string | ||
| description: The phone number of the beneficiary | ||
| registrationNumber: | ||
| type: string | ||
| description: The registration number of the beneficiary | ||
| countryOfResidence: | ||
| type: string | ||
| description: The country of residence of the beneficiary | ||
| address: | ||
| type: object | ||
| required: | ||
| - country | ||
| - line1 | ||
| - postalCode | ||
| properties: | ||
| line1: | ||
| type: string | ||
| description: Address line 1 | ||
| postalCode: | ||
| type: string | ||
| description: Postal code | ||
| country: | ||
| type: string | ||
| description: Country code | ||
| line2: | ||
| type: string | ||
| description: Address line 2 | ||
| city: | ||
| type: string | ||
| description: City | ||
| state: | ||
| type: string | ||
| description: State or province |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed validation patterns, length constraints, and examples that help ensure data quality. The previous schema enforced format
^[0-9]{2}-?[0-9]{2}-?[0-9]{2}$for sortCode and^[0-9]{8}$for accountNumber. Verify this simplification aligns with validation requirements.Prompt To Fix With AI