GPII-1230: Joseph's suggested changes to Kasper's pull request#21
Closed
klown wants to merge 3 commits intokaspermarkus:GPII-1230from
Closed
GPII-1230: Joseph's suggested changes to Kasper's pull request#21klown wants to merge 3 commits intokaspermarkus:GPII-1230from
klown wants to merge 3 commits intokaspermarkus:GPII-1230from
Conversation
Author
|
@kaspermarkus, somehow I managed to reinstate "win32.json" as one of the test data solutions. I'm going to close this pull request, delete my GPII-1230 branch, and then re-create both cleanly. Stay tuned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@kaspermarkus
As noted in my comment on your windows pull request for GPII-1230, here are my changes to the universal code that the windows code depends on.