GPII-1230, GPII-1235, GPII-442: Running application detection and support for more advanced MM#120
GPII-1230, GPII-1235, GPII-442: Running application detection and support for more advanced MM#120kaspermarkus wants to merge 9 commits intoGPII:masterfrom
Conversation
|
CI job passed. |
|
Could we get this updated to master and the conflicts removed? @JavierJF will be looking at this together with his work improving the structure of acceptance tests |
|
CI job failed: https://ci.gpii.net/job/windows-tests/345/ |
|
CI job failed: https://ci.gpii.net/job/windows-tests/346/ |
|
Updated things on universal side, so: ok to test |
|
CI job failed: https://ci.gpii.net/job/windows-tests/347/ |
|
ok to test |
|
CI job failed: https://ci.gpii.net/job/windows-tests/349/ |
|
CI job passed: https://ci.gpii.net/job/windows-tests/352/ |
|
|
||
|
|
||
| gpii.windows.enableRegisteredAT.queryProcessReporter = function (entry) { | ||
| return gpii.processReporter.find(entry.options.queryProcess); |
There was a problem hiding this comment.
This should be routed through gpii.processReporter.handleIsRunning(), where the reference to gpii.processReporter.find() is given via the entry argument. That is, entry.options.queryProcess should look like:
"queryProcess": [
{
"type": "gpii.processReporter.find",
"command": "Magnify.exe"
}
]
...
The technique is to evaluate a list of criteria to determine if a solution is running, and to declare how to do that in a solution's entry.
There was a problem hiding this comment.
Further to my comment above, see the "Special Cases" in the ProcessReporter README, specifically the third paragraph
|
Hey @kaspermarkus I'm checking a few things right now, but expect to see something in the next little while, including some associated changes to the universal code (i.e. two pull requests against your code). |
|
CI job failed: https://ci.gpii.net/job/windows-tests/390/ |
|
Hi there @kaspermarkus - could you update this to current master of universal etc. and check that it is still ok? |
|
CI job passed: https://ci.gpii.net/job/windows-tests/479/ |
|
Closed for #173 |
This branch is compatible with the advanced MM branch GPII-1230 of universal (GPII/universal#507). It contains the (relevant) code from Josephs GPII-442 branch