Conversation
kaushikcfd
force-pushed
the
tighter_write_race_checker
branch
from
ef4761c to
0dde194
Compare
|
Unsubscribing... @-mention or request review once it's ready for a look. |
kaushikcfd
force-pushed
the
tighter_write_race_checker
branch
from
0dde194 to
97fbef5
Compare
inducer
left a comment
inducer
left a comment
There was a problem hiding this comment.
A few quick drive-by comments to start.
kaushikcfd
force-pushed
the
tighter_write_race_checker
branch
from
cbc39e3 to
d2d6a1b
Compare
inducer
left a comment
inducer
left a comment
There was a problem hiding this comment.
Thanks! This LGTM except for the wrinkles highlighted below.
|
|
||
| # }}} | ||
|
|
||
| # {{{ Step 4: make map_a, map_b ISL sets |
There was a problem hiding this comment.
Why is it necessary to convert these to sets? If it is for isl_set_from_expr, I suspect that can be modified trivially to return a Map.
There was a problem hiding this comment.
Why is it necessary to convert these to sets?
I wasn't able to cast the final condition as an intersect operation on the maps.
If it is for
isl_set_from_expr
That's not much important, writing an inequality constraint is a fairly small piece of code.
There was a problem hiding this comment.
I wasn't able to cast the final condition as an intersect operation on the maps.
Shouldn't that just be the same condition? (Not a showstopper for merging, just curious.)
|
Unsubscribing... @-mention or request review once it's ready for a look or needs attention. |
kaushikcfd
force-pushed
the
tighter_write_race_checker
branch
from
d2d6a1b to
1a00c5c
Compare
kaushikcfd
force-pushed
the
tighter_write_race_checker
branch
from
1a00c5c to
403096f
Compare
kaushikcfd
force-pushed
the
tighter_write_race_checker
branch
from
403096f to
55e4782
Compare
kaushikcfd
force-pushed
the
tighter_write_race_checker
branch
from
55e4782 to
46dd439
Compare
|
@inducer: Thanks a lot for the feedback, I've tried to incorporate them in this version. |
… any access races
Intersecting would get ignore some accesses when there's a grid mismatch => Inaccurate.
changes related to callables_table
inducer
force-pushed
the
tighter_write_race_checker
branch
from
60f3b84 to
ba6f26d
Compare
inducer
left a comment
inducer
left a comment
There was a problem hiding this comment.
LGTM, thanks! One non-merge-stopper question below.
|
|
||
| # }}} | ||
|
|
||
| # {{{ Step 4: make map_a, map_b ISL sets |
There was a problem hiding this comment.
I wasn't able to cast the final condition as an intersect operation on the maps.
Shouldn't that just be the same condition? (Not a showstopper for merging, just curious.)
2 participants
Closes: #578