Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1573 +/- ##
===========================================
- Coverage 100.00% 99.75% -0.25%
===========================================
Files 325 338 +13
Lines 24055 24169 +114
===========================================
+ Hits 24055 24110 +55
- Misses 0 58 +58
- Partials 0 1 +1 ☔ View full report in Codecov by Sentry. |
EnriqueL8
left a comment
EnriqueL8
left a comment
There was a problem hiding this comment.
looks good just that docs doesn't make sense
| ### Go version upgrade | ||
|
|
||
| FireFly v1.3.0 now uses Go 1.21 across all modules. | ||
| FireFly v1.3.2 now uses Go 1.22 across all modules. |
There was a problem hiding this comment.
We will have release notes for v1.3.2 separate to this
There was a problem hiding this comment.
I've reverted it under the latest commit, but given that it is a 1.3 migration guide perhaps it's worth having a sentence for both in the docs?
There was a problem hiding this comment.
If you migrate straight to 1.3.2 the docs aren't going to give you useful/accurate information
There was a problem hiding this comment.
Was thinking we have a whole page for v1.3.2 to explain the numbers
There was a problem hiding this comment.
I've just raised #1577 to describe the numbers in the FFBigInt section. Do you think 1.3.2 needs its own migration section? I think the large number support is really just a bug fix i.e. nobody should need to take any action when they migrate, so I was assuming we'd just update the reference section of the docs (as per PR 1577) but not mention as a new feature particuarly.
matthew1001
force-pushed
the
upgrade-go
branch
from
53f3888 to
b5f77c3
Compare
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
matthew1001
force-pushed
the
upgrade-go
branch
from
b5f77c3 to
0254cf5
Compare
EnriqueL8
left a comment
EnriqueL8
left a comment
There was a problem hiding this comment.
Looks good - codecov is doing some weird
3 participants
All FireFly Go modules are being upgraded to Go 1.22. This PR updates Firefly itself, along with miscellaneous docs references.