Merged
Conversation
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
dwertent
reviewed
Sep 11, 2024
Contributor
dwertent
left a comment
dwertent
left a comment
There was a problem hiding this comment.
Perhaps we should first build ff core with go version 22: https://github.com/hyperledger/firefly/blob/4f64fd9e8cd0010637b34b08e10b68f89c2d73b0/manifest.json#L44
Contributor
Author
|
Yeah PR hyperledger/firefly#1573 raised for that - I'll mark this as draft while that PR merges |
Contributor
|
@matthew1001 this ready to be updated? |
Contributor
Author
Yeah - I think it's sorted now that FF is up to date with the latest Go version |
EnriqueL8
approved these changes
Sep 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.