Skip to content

test: fix system test failure in node 18 #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amchiclet merged 5 commits into from
May 4, 2022
Merged

test: fix system test failure in node 18 #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e904b2d
test: fix system test failure in node 18
amchiclet May 3, 2022
7f4a4a8
test: fix setting current directory in system test
amchiclet May 3, 2022
d05269b
test: use SRCDIR variable in system test
amchiclet May 3, 2022
ba587a6
test: initialize retry script after copying source dir
amchiclet May 3, 2022
c1f4a4b
test: add node18 alpine docker file
amchiclet May 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions system-test/Dockerfile.node18-alpine
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
FROM golang:1.17-alpine as builder
RUN apk add --no-cache git
WORKDIR /root/
RUN go get github.com/google/pprof


FROM node:18-alpine

ARG ADDITIONAL_PACKAGES

RUN apk add --no-cache bash $ADDITIONAL_PACKAGES
WORKDIR /root/
COPY --from=builder /go/bin/pprof /bin
RUN chmod a+x /bin/pprof
10 changes: 6 additions & 4 deletions system-test/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
#!/bin/bash

trap "cd $(dirname $0)/.. && npm run clean" EXIT
trap "echo '** TEST FAILED **'" ERR
SRCDIR="/cloned_src"

. $(dirname $0)/../tools/retry.sh
trap "cd $SRCDIR && npm run clean" EXIT
trap "echo '** TEST FAILED **'" ERR

function timeout_after() {
# timeout on Node 11 alpine image requires -t to specify time.
Expand All @@ -19,7 +19,9 @@ npm_install() {
}

set -eox pipefail
cd $(dirname $0)/..
cp -r /src "$SRCDIR"
cd "$SRCDIR"
. "tools/retry.sh"

NODEDIR=$(dirname $(dirname $(which node)))

Expand Down