test: fix system test failure in node 18#214
Merged
amchiclet merged 5 commits intogoogle:mainfrom May 4, 2022
Merged
Conversation
amchiclet
changed the title
amchiclet
force-pushed
the
node-18-system-test-fix
branch
from
8e6e4c3 to
7f4a4a8
Compare
amchiclet
changed the title
nolanmar511
approved these changes
May 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The system tests builds the source from a mounted volume in docker.
Somehow this is causing issues with node 18 which is likely related to permissions/ownership of users outside vs inside the docker container.
This PR clones (
cp -r) the source to a fresh directory that is owned by the user inside the docker container before testing.Also added docker image for node 18 alpine that also used in system test.