refactor: use git cat-file blob instead of git show in readBlobAsBase64 by Copilot · Pull Request #26349 · github/gh-aw

Copilot · 2026-04-15T02:22:47Z

Implements the reviewer suggestion from #26287: since the destination blob hash (dstHash) is already available from the git diff-tree -r --raw output introduced in #26259, there's no need to compose <sha>:<filePath> for git show. Using git cat-file blob <dstHash> directly is simpler (one argument instead of two) and more robust (direct object lookup by hash, no path resolution involved).

Changes

readBlobAsBase64: Signature changed from (sha, filePath, cwd) to (blobHash, cwd). Uses git cat-file blob <blobHash> instead of git show <sha>:<filePath>.
Extract dstHash from modeFields[3] (already guarded by the existing modeFields.length < 5 check).
Update all three call sites (rename, copy, add/modify) to pass dstHash instead of sha, filePath.
Update JSDoc accordingly.

Changeset

Type: patch
Description: Use git cat-file blob <hash> instead of git show <sha>:<path> when reading destination blobs in signed commit push operations, improving robustness and simplifying blob lookup.

Warning

⚠️ Firewall blocked 3 domains

The following domains were blocked by the firewall during workflow execution:

ab.chatgpt.com
chatgpt.com
invalid.example.invalid

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "ab.chatgpt.com"
    - "chatgpt.com"
    - "invalid.example.invalid"

See Network Configuration for more information.

Generated by Changeset Generator for issue #26349 · ◷

✨ PR Review Safe Output Test - Run 24433538607

💥 [THE END] — Illustrated by Smoke Claude · ● 191.9K · ◷

Agent-Logs-Url: https://github.com/github/gh-aw/sessions/399a3c88-0473-46c9-b47e-197bd513dccb Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot

Pull request overview

Refactors readBlobAsBase64 in the signed-commit replay helper to read blob content directly by object hash (from git diff-tree --raw) instead of using git show <sha>:<path>.

Changes:

Update readBlobAsBase64 to accept (blobHash, cwd) and use git cat-file blob <blobHash>.
Extract dstHash from raw diff fields and pass it through rename/copy/add-modify paths.
Add a new repo-level .mcp.json MCP server configuration file.

Show a summary per file

File	Description
actions/setup/js/push_signed_commits.cjs	Switch blob reading to `git cat-file blob <dstHash>` and update helper signature + call sites.
.mcp.json	Adds MCP server configuration pointing at `gh aw mcp-server`.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 2/2 changed files
Comments generated: 2

Copilot · 2026-04-15T02:27:53Z

+ * Read a blob object as a base64-encoded string using `git cat-file blob
+ * <blobHash>`.  The raw bytes emitted by git are collected via the
+ * `exec.exec` stdout listener so that binary files are not corrupted by any
+ * UTF-8 decoding layer (unlike `exec.getExecOutput` which always passes
 * stdout through a `StringDecoder('utf8')`).


The JSDoc inline code for the git command is split across lines, so the backticked snippet ends at git cat-file blob and <blobHash> is no longer part of the code span. This renders oddly and makes the command example ambiguous; consider keeping it as a single inline code span (e.g., git cat-file blob <blobHash>) or use a fenced code block in the comment text.

Suggested change

* Read a blob object as a base64-encoded string using `git cat-file blob

* <blobHash>`. The raw bytes emitted by git are collected via the

* `exec.exec` stdout listener so that binary files are not corrupted by any

* UTF-8 decoding layer (unlike `exec.getExecOutput` which always passes

* stdout through a `StringDecoder('utf8')`).

* Read a blob object as a base64-encoded string using `git cat-file blob <blobHash>`.

* The raw bytes emitted by git are collected via the `exec.exec` stdout

* listener so that binary files are not corrupted by any UTF-8 decoding

* layer (unlike `exec.getExecOutput` which always passes stdout through a

* `StringDecoder('utf8')`).

Copilot · 2026-04-15T02:27:53Z

+{
+  "servers": {
+    "github-agentic-workflows": {
+      "command": "gh",
+      "args": [
+        "aw",
+        "mcp-server"
+      ]
+    }
+  }
+}


This PR’s title/description is focused on refactoring readBlobAsBase64, but this adds a new .mcp.json MCP server configuration file. If this file was generated incidentally (e.g., by running gh aw init), it should be removed from this PR or called out explicitly in the description so reviewers understand the intent and impact of adding a repo-level tool configuration.

Agreed — the .mcp.json file looks like it was incidentally generated and should be called out or removed. Good catch!

📰 BREAKING: Report filed by Smoke Copilot · ● 756K

pelikhan · 2026-04-15T02:29:23Z

@copilot review all comments

Agent-Logs-Url: https://github.com/github/gh-aw/sessions/1d42345b-7c51-488d-8742-525aea3c0abd Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-04-15T02:34:57Z

@copilot review all comments

Both comments addressed in 7bedfc9:

JSDoc backtick: Moved git cat-file blob <blobHash> onto a single line so the inline code span is rendered correctly.
.mcp.json: Removed — it was generated incidentally and is unrelated to this refactoring.

github-actions · 2026-04-15T02:38:50Z

📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing...

github-actions · 2026-04-15T02:38:52Z

✅ All tools validated successfully! Agent Container Smoke Test confirms agent container is ready.

github-actions · 2026-04-15T02:38:54Z

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

github-actions · 2026-04-15T02:38:54Z

🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨

github-actions · 2026-04-15T02:38:57Z

⚠️ Smoke Gemini failed. Gemini encountered unexpected challenges...

github-actions · 2026-04-15T02:41:47Z

Agent Container Tool Check

Tool	Status	Version
bash	✅	5.2.21
sh	✅	available
git	✅	2.53.0
jq	✅	1.7
yq	✅	4.52.5
curl	✅	8.5.0
gh	✅	2.89.0
node	✅	20.20.2
python3	✅	3.12.3
go	✅	1.24.13
java	✅	10.0.201
dotnet	✅	10.0.201

Result: 12/12 tools available ✅

Overall Status: PASS

🔧 Tool validation by Agent Container Smoke Test · ● 157.3K · ◷

github-actions · 2026-04-15T02:44:33Z

Smoke test (Codex) for run 24433538575: FAIL

Merged PRs:

Add shared/reporting.md import to non-compliant reporting workflows #26342 Add shared/reporting.md import to non-compliant reporting workflows
fix: use .mcp.json instead of .vscode/mcp.json for Copilot CLI compatibility #26340 fix: use .mcp.json instead of .vscode/mcp.json for Copilot CLI compatibility

Results: GitHub MCP ✅, Serena activate ✅, Serena find_symbol ❌, Playwright ✅, web-fetch ❌, file write/read ✅, build ✅

Warning

⚠️ Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

ab.chatgpt.com
chatgpt.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "ab.chatgpt.com"
    - "chatgpt.com"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex · ◷

github-actions · 2026-04-15T02:45:36Z

🤖 Smoke Test Results — Run §24433538576\n\n| Test | Status |\n|------|--------|\n| GitHub MCP | ✅ |\n| MCP Scripts GH CLI | ✅ |\n| Serena MCP | ✅ |\n| Playwright | ✅ |\n| Web Fetch | ✅ |\n| File Writing | ✅ |\n| Bash Tool | ✅ |\n| Discussion Interaction | ✅ |\n| Build gh-aw | ✅ |\n| Upload artifact | ✅ |\n| Create Discussion | ✅ |\n| Workflow Dispatch | ✅ |\n| PR Review | ✅ |\n\nOverall: ✅ PASS\n\nPR by @Copilot · Assignees: @pelikhan, @Copilot

📰 BREAKING: Report filed by Smoke Copilot · ● 756K · ◷

github-actions

Clean refactor — the simplified readBlobAsBase64(blobHash, cwd) signature is more focused and direct. Using git cat-file blob over git show sha:path removes path-resolution indirection and aligns with how the blob hash is already available from git diff-tree --raw.

📰 BREAKING: Report filed by Smoke Copilot · ● 756K

github-actions · 2026-04-15T02:45:37Z

+  await exec.exec("git", ["cat-file", "blob", blobHash], {
    cwd,
    silent: true,
    listeners: {


Nice simplification! By accepting blobHash directly instead of (sha, filePath), this function now does exactly one thing: reads a blob by its object hash. This is more robust since it avoids any path resolution ambiguity.

github-actions · 2026-04-15T02:45:37Z

        }
        const srcMode = modeFields[0]; // source file mode (e.g. 100644, 100755, 120000, 160000)
        const dstMode = modeFields[1]; // destination file mode (e.g. 100644, 100755, 120000, 160000)
+        const dstHash = modeFields[3]; // destination blob hash (object ID of the file in this commit)


Good extraction of dstHash from modeFields[3] — it's already available from the git diff-tree --raw output and reusing it avoids the need to compose sha:filePath strings at the call sites.

github-actions · 2026-04-15T02:45:56Z

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

github-actions · 2026-04-15T02:47:52Z

Commit pushed: 4a596b6

Generated by Changeset Generator

github-actions · 2026-04-15T02:48:24Z

Smoke Test: Claude — Run §24433538607

Overall: PARTIAL (1 failed, 2 skipped)

Test	Status
#1 GitHub MCP (merged PRs)	✅
#2 mcpscripts-gh CLI	✅
#3 Serena MCP (find_symbol)	❌ EOF
#4 Make build	✅
#5 Playwright (github.com)	✅
#6 Tavily search	✅
#7 File writing	✅
#8 Bash tool	✅
#9 Discussion comment	✅
#10 Agentic Workflows MCP	✅
#11 Slack safe output	✅
#12 Code scanning alert	✅
#13 Update PR body	✅
#14 PR review comments	✅
#15 Submit PR review	✅
#16 Resolve review thread	⚠️
#17 Add reviewer	✅
#18 Push to PR branch	✅
#19 Close PR	⚠️

💥 [THE END] — Illustrated by Smoke Claude · ● 191.9K · ◷

github-actions

💥 Automated smoke test review - all systems nominal!

💥 [THE END] — Illustrated by Smoke Claude · ● 191.9K

github-actions · 2026-04-15T02:48:25Z

+ * @param {string} blobHash - Object hash of the blob (from `git diff-tree --raw` dstHash field)
 * @param {string} cwd - Working directory of the local git checkout
 * @returns {Promise<string>} Base64-encoded file contents
 */


✅ Clean refactor: using blobHash directly instead of sha + filePath is more precise and avoids potential path-quoting issues. The function signature change is clear and well-documented.

github-actions · 2026-04-15T02:48:25Z

        }
        const srcMode = modeFields[0]; // source file mode (e.g. 100644, 100755, 120000, 160000)
        const dstMode = modeFields[1]; // destination file mode (e.g. 100644, 100755, 120000, 160000)
+        const dstHash = modeFields[3]; // destination blob hash (object ID of the file in this commit)


Good addition of dstHash from modeFields[3]. This aligns with the git diff-tree --raw output format and makes the blob hash available for the refactored readBlobAsBase64 call below.

Copilot AI and others added 2 commits April 15, 2026 02:20

plan: use git cat-file blob instead of git show in readBlobAsBase64

02af44e

Agent-Logs-Url: https://github.com/github/gh-aw/sessions/399a3c88-0473-46c9-b47e-197bd513dccb Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

refactor: use git cat-file blob instead of git show in readBlobAsBase64

a73ccdd

Agent-Logs-Url: https://github.com/github/gh-aw/sessions/399a3c88-0473-46c9-b47e-197bd513dccb Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI assigned Copilot and pelikhan Apr 15, 2026

Copilot created this pull request from a session on behalf of pelikhan April 15, 2026 02:23 View session

Copilot finished work on behalf of pelikhan April 15, 2026 02:23

Copilot AI requested a review from pelikhan April 15, 2026 02:23

pelikhan marked this pull request as ready for review April 15, 2026 02:24

Copilot AI review requested due to automatic review settings April 15, 2026 02:25

Copilot started reviewing on behalf of pelikhan April 15, 2026 02:25 View session

Copilot AI reviewed Apr 15, 2026

View reviewed changes

github-actions bot mentioned this pull request Apr 15, 2026

[aw] No-Op Runs #25214

Closed

Copilot started work on behalf of pelikhan April 15, 2026 02:29 View session

fix: fix JSDoc backtick span and remove unrelated .mcp.json

7bedfc9

Agent-Logs-Url: https://github.com/github/gh-aw/sessions/1d42345b-7c51-488d-8742-525aea3c0abd Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan April 15, 2026 02:35

pelikhan added the smoke label Apr 15, 2026

github-actions bot removed the smoke label Apr 15, 2026

github-actions bot mentioned this pull request Apr 15, 2026

Smoke Test: Copilot - 24433538576 #26354

Closed

github-actions bot added the smoke-copilot label Apr 15, 2026

github-actions bot reviewed Apr 15, 2026

View reviewed changes

Add changeset

19de8b2

github-actions bot mentioned this pull request Apr 15, 2026

Smoke Test: Claude - 24433538607 #26356

Closed

github-actions bot reviewed Apr 15, 2026

View reviewed changes

pelikhan merged commit fde68bb into main Apr 15, 2026

pelikhan deleted the copilot/review-prs-and-investigate-suggestion branch April 15, 2026 02:49

github-actions bot mentioned this pull request Apr 15, 2026

[docs] Update documentation for features merged April 15, 2026 #26399

Merged

Conversation

Copilot AI commented Apr 15, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Changeset

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

pelikhan commented Apr 15, 2026

Uh oh!

Copilot AI commented Apr 15, 2026

Uh oh!

github-actions bot commented Apr 15, 2026

Uh oh!

github-actions bot commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 15, 2026

Agent Container Tool Check

Uh oh!

github-actions bot commented Apr 15, 2026

Uh oh!

github-actions bot commented Apr 15, 2026

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 15, 2026

Uh oh!

github-actions bot commented Apr 15, 2026

Uh oh!

github-actions bot commented Apr 15, 2026

Smoke Test: Claude — Run §24433538607

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Apr 15, 2026 •

edited by github-actions bot

Loading

github-actions bot commented Apr 15, 2026 •

edited

Loading

github-actions bot commented Apr 15, 2026 •

edited

Loading

github-actions bot commented Apr 15, 2026 •

edited

Loading

github-actions bot commented Apr 15, 2026 •

edited

Loading