Skip to content

Add shared/reporting.md import to non-compliant reporting workflows#26342

Merged
pelikhan merged 2 commits intomainfrom
copilot/workflow-style-normalize-report-formatting
Apr 15, 2026
Merged

Add shared/reporting.md import to non-compliant reporting workflows#26342
pelikhan merged 2 commits intomainfrom
copilot/workflow-style-normalize-report-formatting

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 15, 2026

Three active reporting workflows were generating structured reports via add-comment without importing shared/reporting.md, meaning agents lacked explicit guidance on header levels, progressive disclosure, and report structure consistency.

Changes

  • test-quality-sentinel.md — Added new imports: block with shared/reporting.md
  • dev-hawk.md — Added new imports: block with shared/reporting.md
  • design-decision-gate.md — Appended shared/reporting.md to existing imports: list (alongside ../agents/adr-writer.agent.md)
  • Lock files regenerated via make recompile for all three workflows
imports:
  - shared/reporting.md

Brings these three workflows into parity with the six already-compliant reporting workflows (daily-safe-output-optimizer, spec-librarian, approach-validator, etc.).

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/graphql
    • Triggering command: /usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw (http block)
    • Triggering command: /usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw -pack /home/REDACTED/work/gh-aw/gh-aw/cmd/gh-aw/main.go (http block)
  • https://api.github.com/repos/actions/upload-artifact/git/ref/tags/v7
    • Triggering command: /usr/bin/gh gh api /repos/actions/upload-artifact/git/ref/tags/v7 --jq .object.sha (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/upload-artifact/git/ref/tags/v7 --jq .object.sha d -n 10 (http block)
  • https://api.github.com/repos/astral-sh/setup-uv/git/ref/tags/eac588ad8def6316056a12d4907a9d4d84ff7a3b
    • Triggering command: /usr/bin/gh gh api /repos/astral-sh/setup-uv/git/ref/tags/eac588ad8def6316056a12d4907a9d4d84ff7a3b --jq .object.sha (http block)
  • https://api.github.com/repos/docker/build-push-action/git/ref/tags/v7
    • Triggering command: /usr/bin/gh gh api /repos/docker/build-push-action/git/ref/tags/v7 --jq .object.sha (http block)
  • https://api.github.com/repos/githubnext/agentics/git/ref/tags/-
    • Triggering command: /usr/bin/gh gh api /repos/githubnext/agentics/git/ref/tags/- --jq .object.sha (http block)

If you need me to access, download, or install something from one of these locations, you can either:

…sign-decision-gate workflows

Agent-Logs-Url: https://github.com/github/gh-aw/sessions/1511e7c6-3162-42a2-81ef-2bdd371fc25a

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Normalize report formatting for non-compliant workflows Add shared/reporting.md import to non-compliant reporting workflows Apr 15, 2026
Copilot AI requested a review from pelikhan April 15, 2026 01:10
@pelikhan pelikhan marked this pull request as ready for review April 15, 2026 01:23
Copilot AI review requested due to automatic review settings April 15, 2026 01:23
@github-actions

This comment has been minimized.

@github-actions
Copy link
Copy Markdown
Contributor

Great work on this clean, well-scoped consistency improvement! 🎉 Adding the shared/reporting.md import to test-quality-sentinel.md, dev-hawk.md, and design-decision-gate.md is exactly the kind of internal alignment that keeps the workflow library coherent — ensuring all reporting workflows benefit from the shared header-level, progressive disclosure, and report structure guidance.

The only checklist gap is the absence of test file changes. For workflow markdown/config changes, traditional unit tests may not apply, but it's worth confirming the import chain is validated somewhere in CI. The make recompile run (reflected in the updated .lock.yml files) is a good signal, but if there's a lint or schema-validation step that checks for required imports in reporting workflows, that would close the loop entirely.

@pelikhan — please verify that CI's make recompile / validate steps pass cleanly and that the lock file diffs look correct before approving.

If you'd like to add or verify test coverage for this import requirement, here's a prompt to help:

Check whether there are any existing tests in pkg/ or .github/workflows/ that validate the presence of the shared/reporting.md import in reporting workflows (test-quality-sentinel.md, dev-hawk.md, design-decision-gate.md). If such tests exist, confirm they pass. If not, determine whether it is feasible to add a unit test (e.g. in pkg/workflow/ or pkg/parser/) that asserts reporting workflows include the shared/reporting.md import, and implement it following the project's table-driven test conventions with the (go/redacted):build !integration build tag.

Generated by Contribution Check · ● 2M ·

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates three reporting-oriented agentic workflows to explicitly import the shared report-formatting guidance (shared/reporting.md) so generated add-comment reports follow consistent header levels, progressive disclosure, and structure.

Changes:

  • Added imports: - shared/reporting.md to test-quality-sentinel.md and dev-hawk.md.
  • Appended shared/reporting.md to the existing imports list in design-decision-gate.md.
  • Regenerated the corresponding .lock.yml files via make recompile to reflect the new imports/runtime-imports.
Show a summary per file
File Description
.github/workflows/test-quality-sentinel.md Adds shared/reporting.md import so test quality comments follow the shared report structure.
.github/workflows/test-quality-sentinel.lock.yml Recompiled lock manifest/runtime-imports to include the new shared reporting import.
.github/workflows/dev-hawk.md Adds shared/reporting.md import for consistent Dev Hawk PR comment formatting.
.github/workflows/dev-hawk.lock.yml Recompiled lock manifest/runtime-imports to include the new shared reporting import.
.github/workflows/design-decision-gate.md Appends shared/reporting.md to imports to standardize ADR gate output formatting.
.github/workflows/design-decision-gate.lock.yml Recompiled lock manifest/runtime-imports to include the new shared reporting import.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 6/6 changed files
  • Comments generated: 0

@github-actions github-actions bot mentioned this pull request Apr 15, 2026
@pelikhan pelikhan merged commit 190f193 into main Apr 15, 2026
78 checks passed
@pelikhan pelikhan deleted the copilot/workflow-style-normalize-report-formatting branch April 15, 2026 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[workflow-style] Normalize report formatting for non-compliant workflows

3 participants