Add shared/reporting.md import to non-compliant reporting workflows#26342
Add shared/reporting.md import to non-compliant reporting workflows#26342
Conversation
…sign-decision-gate workflows Agent-Logs-Url: https://github.com/github/gh-aw/sessions/1511e7c6-3162-42a2-81ef-2bdd371fc25a Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
|
Great work on this clean, well-scoped consistency improvement! 🎉 Adding the The only checklist gap is the absence of test file changes. For workflow markdown/config changes, traditional unit tests may not apply, but it's worth confirming the import chain is validated somewhere in CI. The
If you'd like to add or verify test coverage for this import requirement, here's a prompt to help:
|
There was a problem hiding this comment.
Pull request overview
Updates three reporting-oriented agentic workflows to explicitly import the shared report-formatting guidance (shared/reporting.md) so generated add-comment reports follow consistent header levels, progressive disclosure, and structure.
Changes:
- Added
imports: - shared/reporting.mdtotest-quality-sentinel.mdanddev-hawk.md. - Appended
shared/reporting.mdto the existing imports list indesign-decision-gate.md. - Regenerated the corresponding
.lock.ymlfiles viamake recompileto reflect the new imports/runtime-imports.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/test-quality-sentinel.md | Adds shared/reporting.md import so test quality comments follow the shared report structure. |
| .github/workflows/test-quality-sentinel.lock.yml | Recompiled lock manifest/runtime-imports to include the new shared reporting import. |
| .github/workflows/dev-hawk.md | Adds shared/reporting.md import for consistent Dev Hawk PR comment formatting. |
| .github/workflows/dev-hawk.lock.yml | Recompiled lock manifest/runtime-imports to include the new shared reporting import. |
| .github/workflows/design-decision-gate.md | Appends shared/reporting.md to imports to standardize ADR gate output formatting. |
| .github/workflows/design-decision-gate.lock.yml | Recompiled lock manifest/runtime-imports to include the new shared reporting import. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 6/6 changed files
- Comments generated: 0
Three active reporting workflows were generating structured reports via
add-commentwithout importingshared/reporting.md, meaning agents lacked explicit guidance on header levels, progressive disclosure, and report structure consistency.Changes
test-quality-sentinel.md— Added newimports:block withshared/reporting.mddev-hawk.md— Added newimports:block withshared/reporting.mddesign-decision-gate.md— Appendedshared/reporting.mdto existingimports:list (alongside../agents/adr-writer.agent.md)make recompilefor all three workflowsBrings these three workflows into parity with the six already-compliant reporting workflows (
daily-safe-output-optimizer,spec-librarian,approach-validator, etc.).Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/graphql/usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw(http block)/usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw -pack /home/REDACTED/work/gh-aw/gh-aw/cmd/gh-aw/main.go(http block)https://api.github.com/repos/actions/upload-artifact/git/ref/tags/v7/usr/bin/gh gh api /repos/actions/upload-artifact/git/ref/tags/v7 --jq .object.sha(http block)/usr/bin/gh gh api /repos/actions/upload-artifact/git/ref/tags/v7 --jq .object.sha d -n 10(http block)https://api.github.com/repos/astral-sh/setup-uv/git/ref/tags/eac588ad8def6316056a12d4907a9d4d84ff7a3b/usr/bin/gh gh api /repos/astral-sh/setup-uv/git/ref/tags/eac588ad8def6316056a12d4907a9d4d84ff7a3b --jq .object.sha(http block)https://api.github.com/repos/docker/build-push-action/git/ref/tags/v7/usr/bin/gh gh api /repos/docker/build-push-action/git/ref/tags/v7 --jq .object.sha(http block)https://api.github.com/repos/githubnext/agentics/git/ref/tags/-/usr/bin/gh gh api /repos/githubnext/agentics/git/ref/tags/- --jq .object.sha(http block)If you need me to access, download, or install something from one of these locations, you can either: