chore(size-limit): Add size checks for metrics and logs #18573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report 📦
|
Lms24
commented
Dec 19, 2025
| { | ||
| name: '@sentry/browser (incl. Metrics)', | ||
| path: 'packages/browser/build/npm/esm/prod/index.js', | ||
| import: createImport('init', 'metrics'), |
Member
Author
There was a problem hiding this comment.
tbh, I was surprised that the import of metrics and logs is enough in this case because I was under the impression that just importing this object would still tree-shake the implementation of the individual log/metric operations.
However, I inspected the bundle created by size-limit and it turns out that they're still included.
Also further verified this with creating a custom entry file and writing logger.info, etc statements and in either case, the resulting bundle was smaller than just specifying the logger/metric import. So I think we should take this as the upper bound.
chargome
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 3 size-limit entries for logs, metrics and both combined. I have some optimizations lined up for reducing bundle size in both but I need a baseline to see if they actually do any good.
ref #18571
ref #18164