Skip to content

Conversation

@Lms24
Copy link
Member

@Lms24 Lms24 commented Dec 18, 2025

  • feat(core): Apply scope attributes to metrics
  • fix tests after rename

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).
  • Link an issue if there is one related to your pull request. If no issue is linked, one will be auto-generated and linked.

Closes #18160

@Lms24 Lms24 self-assigned this Dec 18, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 24.82 kB - -
@sentry/browser - with treeshaking flags 23.32 kB - -
@sentry/browser (incl. Tracing) 41.59 kB - -
@sentry/browser (incl. Tracing, Profiling) 46.2 kB - -
@sentry/browser (incl. Tracing, Replay) 80.18 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 69.91 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 84.87 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 97.1 kB - -
@sentry/browser (incl. Feedback) 41.54 kB - -
@sentry/browser (incl. sendFeedback) 29.51 kB - -
@sentry/browser (incl. FeedbackAsync) 34.5 kB - -
@sentry/browser (incl. Metrics) 25.93 kB +0.3% +77 B 🔺
@sentry/browser (incl. Logs) 26.07 kB - -
@sentry/browser (incl. Metrics & Logs) 26.7 kB -0.11% -29 B 🔽
@sentry/react 26.54 kB - -
@sentry/react (incl. Tracing) 43.79 kB - -
@sentry/vue 29.29 kB - -
@sentry/vue (incl. Tracing) 43.41 kB - -
@sentry/svelte 24.84 kB - -
CDN Bundle 27.33 kB +0.29% +78 B 🔺
CDN Bundle (incl. Tracing) 42.34 kB +0.25% +103 B 🔺
CDN Bundle (incl. Tracing, Replay) 79.05 kB +0.13% +96 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 84.49 kB +0.09% +72 B 🔺
CDN Bundle - uncompressed 80.32 kB +0.33% +260 B 🔺
CDN Bundle (incl. Tracing) - uncompressed 125.67 kB +0.21% +260 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 242.2 kB +0.11% +260 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 254.97 kB +0.11% +260 B 🔺
@sentry/nextjs (client) 46.01 kB - -
@sentry/sveltekit (client) 41.97 kB - -
@sentry/node-core 51.61 kB -0.01% -2 B 🔽
@sentry/node 161.51 kB -0.01% -2 B 🔽
@sentry/node - without tracing 93.05 kB -0.01% -1 B 🔽
@sentry/aws-serverless 108.56 kB -0.01% -3 B 🔽

View base workflow run

@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2025

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 8,942 - 9,015 -1%
GET With Sentry 1,720 19% 1,736 -1%
GET With Sentry (error only) 5,971 67% 6,095 -2%
POST Baseline 1,202 - 1,202 -
POST With Sentry 588 49% 612 -4%
POST With Sentry (error only) 1,049 87% 1,069 -2%
MYSQL Baseline 3,266 - 3,358 -3%
MYSQL With Sentry 479 15% 504 -5%
MYSQL With Sentry (error only) 2,673 82% 2,687 -1%

View base workflow run

@Lms24 Lms24 force-pushed the lms/feat-metrics-scope-attributes branch from 2e7cf83 to d0ec81b Compare December 19, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Apply scope attributes to metrics

2 participants