Add docstrings and make pep8 changes #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthieuBizien
added a commit
to MatthieuBizien/Minecraft
that referenced
this pull request
Dec 18, 2020
Like fogleman#35, I believe that project is a great educational tool, an impressive achievement, and a reference for clean Python code. Warnings F403 and F405 are currently ignored. That could be removed when fogleman#124 is merged. Warnings E128,E201,E226,E231 could be removed if autopep8 or similar is used. I advise to merge fogleman#124 before, to limit the risk of merge conflict. I fixed 3 small pep8 issues in main.py too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings pep8 fixes and docstrings. I have also removed the definition of
TextureGroupfrom the main module and instead imported it frompyglet.I love this project and I think it has a great potential to inspire kids who want to get into programming. To that end I think documentation and pep8 styling will make this easier.
If I get more time in the future I may go through and add more comments explaining the actual implementation. (I need to learn pyglet first ;))