Code formatting and separates keyboard bindings. #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
are you using AZERTY Keyb??? |
Author
|
Whoops, sorry, I forgot to change that back :) Fixed. |
Owner
|
PEP 8 applied via #35 |
Author
|
Do I open another pull request only with keyboard bindings? |
Owner
|
Seems excessive to add a whole settings package just for that at this point. |
Author
|
I thought that could be a start, but as you wish. |
|
I agree with Bertrand. It would be nice to have a package just for handle keyboard inputs, another to graphics, sounds and etc. And separate the logic from the presentation. The main.py script has flux control, pyglet code and class definitions (as Player). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.