fix: release drafter permission error#1482
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1482 +/- ##
=======================================
Coverage 89.66% 89.66%
=======================================
Files 68 68
Lines 4869 4869
Branches 888 888
=======================================
Hits 4366 4366
Misses 485 485
Partials 18 18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
367683b to
f7f2bfb
Compare
3150b6c to
2f2848f
Compare
c10ae96 to
9d2af8d
Compare
coopernetes
left a comment
There was a problem hiding this comment.
LGTM, we'll need the help of @TheJuanAndOnly99 / @finos-admin to get this merged.
Juan, mind helping us to override this PR? This fixes the error shown which is generating the failed required check to unblock other PRs. Thanks!!
|
hi @coopernetes happy to help. Just to confirm, this PR needs to be merged? |
Hey @TheJuanAndOnly99 , yes thats correct this one is needed to unblock others since it requires this change in |
|
@coopernetes merged! |
Fixes #1481 by giving write permissions to the release drafter action.
Note that the PR needs to be force-merged in order to take effect in the CI, as it's set to run on
pull_request_target.In order to test this, I set the CI to temporarily run on
[pull_request], which successfully generated a draft release for "Version 1.20.0".This is the action output after the fix:
The
commitishoption is described here. Although not necessary, it makes it run onmainexplicitly rather than in other places (in case theon: pull_request_targetbit is ever modified).