Skip to content

fix: release drafter permission error#1482

Merged
finos-admin merged 2 commits intomainfrom
1481-fix-release-drafter-permissions
Mar 26, 2026
Merged

fix: release drafter permission error#1482
finos-admin merged 2 commits intomainfrom
1481-fix-release-drafter-permissions

Conversation

@jescalada
Copy link
Copy Markdown
Contributor

@jescalada jescalada commented Mar 25, 2026

Fixes #1481 by giving write permissions to the release drafter action.

Note that the PR needs to be force-merged in order to take effect in the CI, as it's set to run on pull_request_target.

In order to test this, I set the CI to temporarily run on [pull_request], which successfully generated a draft release for "Version 1.20.0".

This is the action output after the fix:

image

The commitish option is described here. Although not necessary, it makes it run on main explicitly rather than in other places (in case the on: pull_request_target bit is ever modified).

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 25, 2026

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 9d2af8d
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/69c36d80ed2778000808434d

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 25, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 9d2af8d.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.66%. Comparing base (50f88d7) to head (9d2af8d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1482   +/-   ##
=======================================
  Coverage   89.66%   89.66%           
=======================================
  Files          68       68           
  Lines        4869     4869           
  Branches      888      888           
=======================================
  Hits         4366     4366           
  Misses        485      485           
  Partials       18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jescalada jescalada force-pushed the 1481-fix-release-drafter-permissions branch from 367683b to f7f2bfb Compare March 25, 2026 04:37
@jescalada jescalada marked this pull request as ready for review March 25, 2026 04:41
@jescalada jescalada requested a review from a team as a code owner March 25, 2026 04:41
@jescalada jescalada force-pushed the 1481-fix-release-drafter-permissions branch from 3150b6c to 2f2848f Compare March 25, 2026 04:49
@jescalada jescalada force-pushed the 1481-fix-release-drafter-permissions branch from c10ae96 to 9d2af8d Compare March 25, 2026 05:07
Copy link
Copy Markdown
Contributor

@coopernetes coopernetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we'll need the help of @TheJuanAndOnly99 / @finos-admin to get this merged.

Juan, mind helping us to override this PR? This fixes the error shown which is generating the failed required check to unblock other PRs. Thanks!!

@coopernetes coopernetes enabled auto-merge (squash) March 25, 2026 14:36
@coopernetes coopernetes disabled auto-merge March 25, 2026 14:37
@coopernetes coopernetes enabled auto-merge March 25, 2026 14:37
@TheJuanAndOnly99
Copy link
Copy Markdown
Member

hi @coopernetes happy to help. Just to confirm, this PR needs to be merged?

@coopernetes
Copy link
Copy Markdown
Contributor

hi @coopernetes happy to help. Just to confirm, this PR needs to be merged?

Hey @TheJuanAndOnly99 , yes thats correct this one is needed to unblock others since it requires this change in main (via pull_request_target trigger).

@finos-admin finos-admin disabled auto-merge March 26, 2026 13:54
@finos-admin finos-admin merged commit 232980a into main Mar 26, 2026
21 of 23 checks passed
@finos-admin
Copy link
Copy Markdown
Member

@coopernetes merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix/remove failing release-drafter.yml job

4 participants