feat: Add action summary to push view#1446
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1446 +/- ##
=======================================
Coverage 89.66% 89.66%
=======================================
Files 68 68
Lines 4869 4869
Branches 888 888
=======================================
Hits 4366 4366
Misses 485 485
Partials 18 18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
re-vlad
left a comment
There was a problem hiding this comment.
lets couple of non-blocking suggestions
jescalada
left a comment
There was a problem hiding this comment.
Fantastic contribution @andypols! 🚀 This is super useful for debugging pushes that errored out without having to dig through logs. The latest logging enhancements should help improve this further!
I'd just like to double-check that everything being logged is appropriate for the user to see, and that the recently added step.logs aren't excessive (otherwise we might want to add them to isLargeStep).
Summary
It can be hard to understand why a push was rejected. This PR adds a view of each step involved in a push, making it easier to identify failures. It also fixes #1387 and prevents the UI from crashing when a push fails before a diff is generated.
We use "steps" instead of actions in the UI, since “actions” was confusing for users.
Solution
CustomTabsto support an optional badge.