Skip to content

feat: Add action summary to push view#1446

Merged
andypols merged 15 commits intofinos:mainfrom
qube-rt:display-git-push-actions
Mar 26, 2026
Merged

feat: Add action summary to push view#1446
andypols merged 15 commits intofinos:mainfrom
qube-rt:display-git-push-actions

Conversation

@andypols
Copy link
Copy Markdown
Contributor

@andypols andypols commented Mar 5, 2026

Summary

It can be hard to understand why a push was rejected. This PR adds a view of each step involved in a push, making it easier to identify failures. It also fixes #1387 and prevents the UI from crashing when a push fails before a diff is generated.

We use "steps" instead of actions in the UI, since “actions” was confusing for users.

Solution

  • Introduces a tabbed view for push data, including Commits, Diff, and Steps. This reduces scrolling and provides a foundation for future additions, such as an AI-generated change summary (future PR).
CleanShot 2026-03-06 at 08 38 11@2x
  • Adds dedicated components for each tab.
  • Extended CustomTabs to support an optional badge.
  • Calculates the total error count across steps and displays it as a badge to make failures more visible.
  • Sums the error count from the steps and displays an error count as a badge to highlight there are errors.
  • Adds a StepsTimeline component featuring an accordion layout, status chips, and log output to better surface errors, blocked steps, and successful execution.
CleanShot 2026-03-06 at 08 39 41@2x
  • Clicking on an accordion step the info about that action
CleanShot 2026-03-06 at 08 42 19@2x
  • Prevents large step payloads from being rendered.

@andypols andypols requested a review from a team as a code owner March 5, 2026 23:36
@netlify
Copy link
Copy Markdown

netlify bot commented Mar 5, 2026

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 01c544f
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/69c586ec23c11100084af6a9

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.66%. Comparing base (232980a) to head (01c544f).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1446   +/-   ##
=======================================
  Coverage   89.66%   89.66%           
=======================================
  Files          68       68           
  Lines        4869     4869           
  Branches      888      888           
=======================================
  Hits         4366     4366           
  Misses        485      485           
  Partials       18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown

@re-vlad re-vlad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets couple of non-blocking suggestions

Copy link
Copy Markdown
Contributor

@jescalada jescalada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic contribution @andypols! 🚀 This is super useful for debugging pushes that errored out without having to dig through logs. The latest logging enhancements should help improve this further!

I'd just like to double-check that everything being logged is appropriate for the user to see, and that the recently added step.logs aren't excessive (otherwise we might want to add them to isLargeStep).

@andypols andypols requested a review from jescalada March 20, 2026 10:14
Copy link
Copy Markdown
Contributor

@jescalada jescalada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Might have to wait for #1482 to get merged first so that the CI passes as expected.

@andypols andypols merged commit 4e2eea8 into finos:main Mar 26, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

4 participants