You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm not convinced this change is much of an improvement, please motivate such changes: What's the rationale? Nevertheless, I would prefer to move concatenating text sequences upstream and consider this a temporary solution, which does is job.
Since "ontext" behave differently whether the writing is done in a stream way or not, it was just an attempt to make this "temporary solution" easier to understand since I had some troubles to get what use cases the big conditions was related to. I thought that reducing them into a single if (this._activeTextNode) { would be easier to understand but it was just a personnal taste.
Anyhow you're right, having another event like "onbody", "oncontent" or an {eager: true} option would be a way better solution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a minor refactoring to simplify the 'ontext' handler.