Tutorial ported to ES6 classes or stateless functions #6846
Conversation
getInitialState does not work with ES6 style class instantiations.
class Component extends React.Component {
constructor(props) {
this.state = props;
}
}
|
I actually think that we need to do a more extensive overhaul of the tutorial to make functional and ES6 components fit more naturally. |
|
Why use |
|
@zpao Can you be more specific? I am a beginner in React, inputs would be helpful in porting this tutorial. |
|
@zpao I agree with you, but is there any harm in taking this change since it is incrementally closer to our end goal? |
|
@jimfb If we end up doing a worse job of teaching React, then absolutely. We should be coordinating efforts to update the site for ES6 and make sure it's better. We should not land partial incremental updates that leave us in a state that is not better. |
| text: '' | ||
| } | ||
| } | ||
| handleAuthorChange = (e) => { |
There was a problem hiding this comment.
Why not handleAuthorChange() {?
There was a problem hiding this comment.
Let's put a pin in this for the time being to prevent over-churn. I don't know that we will be encouraging the use of property initializers yet. We'll want to make sure we have some guidelines for code in documentation before we finalize this.
There was a problem hiding this comment.
I think we should stick with the current version of JavaScript. So no property initalizers.
ghost
added
the
|
Hey, sorry so much for letting this get stale. This is totally my fault. 😢 We are working on revamping the docs right now. As a first phase we are merging the PRs from #3710 but unfortunately I can't merge yours because we decided to replace this tutorial with a new one written from scratch. |
7 participants
Issue reference : #3710
Before submitting a pull request, please make sure the following is done...
master.grunt test).grunt lint) - we've done our best to make sure these rules match our internal linting guidelines.