Improved suspense support in ReactDOMServer

[alexmckenley]

I've updated the support for suspense in the ReactPartialRenderer. Instead of always rendering the fallback, the server renderer will attempt to render the children, and only revert to the fallback if rendering is suspended with a thrown promise.

Let me know what you think.

[sizebot]

Details of bundled changes.

Comparing: f9e9913...7483480

react-dom

File	Filesize Diff	Gzip Diff	Prev Size	Current Size	Prev Gzip	Current Gzip	ENV
react-dom-server.browser.development.js	+1.3%	+1.1%	119.2 KB	120.8 KB	31.71 KB	32.05 KB	UMD_DEV
react-dom-server.browser.production.min.js	🔺+2.0%	🔺+2.0%	16.02 KB	16.34 KB	6.09 KB	6.21 KB	UMD_PROD
react-dom-server.browser.development.js	+1.4%	+1.1%	115.33 KB	116.93 KB	30.76 KB	31.09 KB	NODE_DEV
react-dom-server.browser.production.min.js	🔺+2.0%	🔺+1.9%	15.92 KB	16.24 KB	6.09 KB	6.2 KB	NODE_PROD
react-dom-server.node.development.js	+1.4%	+1.1%	117.25 KB	118.85 KB	31.29 KB	31.62 KB	NODE_DEV
react-dom-server.node.production.min.js	🔺+2.0%	🔺+1.8%	16.72 KB	17.05 KB	6.39 KB	6.5 KB	NODE_PROD
ReactDOMServer-dev.js	+1.4%	+1.2%	116.43 KB	118.09 KB	30.38 KB	30.74 KB	FB_WWW_DEV
ReactDOMServer-prod.js	🔺+3.5%	🔺+2.7%	40.65 KB	42.08 KB	9.58 KB	9.83 KB	FB_WWW_PROD

scheduler

File	Filesize Diff	Gzip Diff	Prev Size	Current Size	Prev Gzip	Current Gzip	ENV
scheduler.development.js	n/a	n/a	0 B	19.17 KB	0 B	5.74 KB	UMD_DEV
scheduler.production.min.js	n/a	n/a	0 B	3.16 KB	0 B	1.53 KB	UMD_PROD

Generated by 🚫 dangerJS

[alexmckenley]

Updated based on recommendations from @sophiebits. 💯

[sophiebits]

Thanks! Feel free to squash-and-merge when you're ready.

[alexmckenley]

@sophiebits Thanks for the review! I pushed up the changes, but I dont see a merge button, seems like I may not have permission.

[Tor01100]

dom/src/server/ReactPartialRenderer.js index 643d53cf0c3..c5f124e7c4a 100644 Can't be running in js try using HTML script for the patch for #6846

…

On Thu, Nov 8, 2018, 6:54 PM Alex Taylor ***@***.*** wrote: Updated based on recommendations from @sophiebits <https://github.com/sophiebits>. 💯 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#14161 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AYjb0Li0DKHPcI-IuFII33pQnteWecrdks5utNI5gaJpZM4YVuTD> .