Update atrifact names to the new ones#52618
Closed
cipolleschi wants to merge 1 commit intofacebook:mainfrom
Closed
Update atrifact names to the new ones#52618cipolleschi wants to merge 1 commit intofacebook:mainfrom
cipolleschi wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: In 0.81 we dropped the JSC configuration in CI. That means that the artifacts we generate in CI have a slightly different name. The current e2e script failed to run with the ci flag because it was still using the old artifacts name and it was not finding them. This change adress the problem by: - using the right artifact names - removing the --hermes parameter which controlled the Hermes vs JSC scenario. It is also a port to main of [this PR](facebook#52606) ## Changelog: [Internal] - Differential Revision: D78344244
meta-cla
bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78344244 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jul 15, 2025
Summary: In 0.81 we dropped the JSC configuration in CI. That means that the artifacts we generate in CI have a slightly different name. The current e2e script failed to run with the ci flag because it was still using the old artifacts name and it was not finding them. This change adress the problem by: - using the right artifact names - removing the --hermes parameter which controlled the Hermes vs JSC scenario. It is also a port to main of [this PR](facebook#52606) ## Changelog: [Internal] - Reviewed By: vzaidman Differential Revision: D78344244
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jul 15, 2025
Summary: In 0.81 we dropped the JSC configuration in CI. That means that the artifacts we generate in CI have a slightly different name. The current e2e script failed to run with the ci flag because it was still using the old artifacts name and it was not finding them. This change adress the problem by: - using the right artifact names - removing the --hermes parameter which controlled the Hermes vs JSC scenario. It is also a port to main of [this PR](facebook#52606) ## Changelog: [Internal] - Reviewed By: vzaidman Differential Revision: D78344244
Contributor
|
This pull request has been merged in 339dc49. |
Collaborator
|
This pull request was successfully merged by @cipolleschi in 339dc49 When will my fix make it into a release? | How to file a pick request? |
kikoso
pushed a commit
to kikoso/react-native
that referenced
this pull request
Aug 26, 2025
Summary: Pull Request resolved: facebook#52618 In 0.81 we dropped the JSC configuration in CI. That means that the artifacts we generate in CI have a slightly different name. The current e2e script failed to run with the ci flag because it was still using the old artifacts name and it was not finding them. This change adress the problem by: - using the right artifact names - removing the --hermes parameter which controlled the Hermes vs JSC scenario. It is also a port to main of [this PR](facebook#52606) ## Changelog: [Internal] - Reviewed By: cortinico, vzaidman Differential Revision: D78344244 fbshipit-source-id: a658ba161b867bbad773fe093df9679ea92579b3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
In 0.81 we dropped the JSC configuration in CI. That means that the artifacts we generate in CI have a slightly different name. The current e2e script failed to run with the ci flag because it was still using the old artifacts name and it was not finding them.
This change adress the problem by:
It is also a port to main of this PR
Changelog:
[Internal] -
Differential Revision: D78344244