Skip to content

[LOCAL][RN][Release]Fix E2E script when using CI artifacts#52606

Merged
motiz88 merged 1 commit into0.81-stablefrom
cipolleschi/fix-e2e-script-with-ci
Jul 21, 2025
Merged

[LOCAL][RN][Release]Fix E2E script when using CI artifacts#52606
motiz88 merged 1 commit into0.81-stablefrom
cipolleschi/fix-e2e-script-with-ci

Conversation

@cipolleschi
Copy link
Contributor

@cipolleschi cipolleschi commented Jul 15, 2025

Summary:

In 0.81 we dropped the JSC configuration in CI. That means that the artifacts we generate in CI have a slightly different name. The current e2e script failed to run with the ci flag because it was still using the old artifacts name and it was not finding them.

This change adress the problem by:

  • using the right artifact names
  • removing the --hermes parameter which controlled the Hermes vs JSC scenario.

Changelog:

[Internal] -

Test Plan:

tested locally.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 15, 2025
@cipolleschi cipolleschi changed the base branch from main to 0.81-stable July 15, 2025 12:31
@cipolleschi cipolleschi marked this pull request as ready for review July 15, 2025 13:40
@cipolleschi cipolleschi force-pushed the cipolleschi/fix-e2e-script-with-ci branch 2 times, most recently from ce1bb62 to 5893442 Compare July 15, 2025 14:51
@cipolleschi cipolleschi force-pushed the cipolleschi/fix-e2e-script-with-ci branch from 5893442 to c895991 Compare July 15, 2025 15:00
@cipolleschi cipolleschi force-pushed the cipolleschi/fix-e2e-script-with-ci branch from c895991 to 4f7a930 Compare July 15, 2025 15:00
cipolleschi added a commit to cipolleschi/react-native that referenced this pull request Jul 15, 2025
Summary:

In 0.81 we dropped the JSC configuration in CI. That means that the artifacts we generate in CI have a slightly different name. The current e2e script failed to run with the ci flag because it was still using the old artifacts name and it was not finding them.

This change adress the problem by:

- using the right artifact names
- removing the --hermes parameter which controlled the Hermes vs JSC scenario.

It is also a port to main of [this PR](facebook#52606)

## Changelog:
[Internal] -

Reviewed By: vzaidman

Differential Revision: D78344244
cipolleschi added a commit to cipolleschi/react-native that referenced this pull request Jul 15, 2025
Summary:

In 0.81 we dropped the JSC configuration in CI. That means that the artifacts we generate in CI have a slightly different name. The current e2e script failed to run with the ci flag because it was still using the old artifacts name and it was not finding them.

This change adress the problem by:

- using the right artifact names
- removing the --hermes parameter which controlled the Hermes vs JSC scenario.

It is also a port to main of [this PR](facebook#52606)

## Changelog:
[Internal] -

Reviewed By: vzaidman

Differential Revision: D78344244
facebook-github-bot pushed a commit that referenced this pull request Jul 15, 2025
Summary:
Pull Request resolved: #52618

In 0.81 we dropped the JSC configuration in CI. That means that the artifacts we generate in CI have a slightly different name. The current e2e script failed to run with the ci flag because it was still using the old artifacts name and it was not finding them.

This change adress the problem by:

- using the right artifact names
- removing the --hermes parameter which controlled the Hermes vs JSC scenario.

It is also a port to main of [this PR](#52606)

## Changelog:
[Internal] -

Reviewed By: cortinico, vzaidman

Differential Revision: D78344244

fbshipit-source-id: a658ba161b867bbad773fe093df9679ea92579b3
@motiz88 motiz88 merged commit d8bf944 into 0.81-stable Jul 21, 2025
75 checks passed
kikoso pushed a commit to kikoso/react-native that referenced this pull request Aug 26, 2025
Summary:
Pull Request resolved: facebook#52618

In 0.81 we dropped the JSC configuration in CI. That means that the artifacts we generate in CI have a slightly different name. The current e2e script failed to run with the ci flag because it was still using the old artifacts name and it was not finding them.

This change adress the problem by:

- using the right artifact names
- removing the --hermes parameter which controlled the Hermes vs JSC scenario.

It is also a port to main of [this PR](facebook#52606)

## Changelog:
[Internal] -

Reviewed By: cortinico, vzaidman

Differential Revision: D78344244

fbshipit-source-id: a658ba161b867bbad773fe093df9679ea92579b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants