-
Notifications
You must be signed in to change notification settings - Fork 245
fix: return soft-confirmed batches #2180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: return soft-confirmed batches #2180
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/exec_api #2180 +/- ##
====================================================
- Coverage 29.41% 28.04% -1.37%
====================================================
Files 62 58 -4
Lines 6824 6647 -177
====================================================
- Hits 2007 1864 -143
+ Misses 4600 4564 -36
- Partials 217 219 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Return batches before DA submission, to make Single sequencer compatible to the spec (ADR). Resolves #2179
…provements This commit introduces context management in the sequencer's initialization and submission processes, ensuring better control over timeouts. Additionally, it adds new tests to validate the behavior of the sequencer when handling rollup transactions before data availability (DA) submission, improving overall test coverage and reliability.
b21993b to
565c80b
Compare
Overview
Return batches before DA submission, to make Single sequencer compatible to the spec (ADR).
Resolves #2179