Skip to content

fix: force checking lazy_aggregator flag #1704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Manav-Aggarwal merged 2 commits into from
Jun 12, 2024
Merged

fix: force checking lazy_aggregator flag #1704

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac6085b
force checking lazy_aggregator flag
yarikbratashchuk Jun 12, 2024
92b7fb9
Merge branch 'main' into yarik/lazy_agg
yarikbratashchuk Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions cmd/rollkit/commands/run_node.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,11 @@ func NewRunNodeCmd() *cobra.Command {
// initialize the metrics
metrics := rollnode.DefaultMetricsProvider(cometconf.DefaultInstrumentationConfig())

// handle lazy aggregator mode
if lazyAgg := cmd.Flags().Lookup("rollkit.lazy_aggregator"); lazyAgg.Changed {
rollkitConfig.LazyAggregator = lazyAgg.Value.String() == "true"
}

// use mock jsonrpc da server by default
if !cmd.Flags().Lookup("rollkit.da_address").Changed {
srv, err := startMockDAServJSONRPC(cmd.Context())
Expand Down