-
Notifications
You must be signed in to change notification settings - Fork 245
fix: force checking lazy_aggregator flag #1704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughA new logic has been introduced in the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant CLI
participant RunNodeCmd
participant RollkitConfig
User->>CLI: Run command with lazy aggregator flag
CLI->>RunNodeCmd: Initialize NewRunNodeCmd
RunNodeCmd->>RunNodeCmd: Check lazy aggregator flag
alt Flag is set
RunNodeCmd->>RollkitConfig: Set LazyAggregator to true
else Flag is not set
RunNodeCmd->>RollkitConfig: Set LazyAggregator to false
end
RunNodeCmd->>CLI: Execute node with updated RollkitConfig
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a follow up scope of work, we probably need to go through and make sure that all flags are handled.
And with that, we probably would want some helper that can be called to pull all flags into the config.
Documented in: #1705 |
Summary by CodeRabbit