[release/7.0-rc1] Move runtimeconfig.template.json stuff to csproj#74144
Merged
carlossanlop merged 3 commits intorelease/7.0-rc1from Aug 18, 2022
Merged
[release/7.0-rc1] Move runtimeconfig.template.json stuff to csproj#74144carlossanlop merged 3 commits intorelease/7.0-rc1from
carlossanlop merged 3 commits intorelease/7.0-rc1from
Conversation
NativeAOT ignores this and emits a warning. This fails the test build.
…sources.ResourceManager.Tests.csproj
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
jeffschwMSFT
approved these changes
Aug 18, 2022
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. Please get a code review and once we get a green ci we can merge.
Contributor
|
The CI failure is unrelated (System.Net.Http.Functional.Tests). Strangely, the log file says nothing failed:
So I think we're good. It's been approved and signed off. Ready to merge. |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #74124 to release/7.0-rc1
/cc @MichalStrehovsky
Customer Impact
Test only change. We need this to get extra-platforms legs green.
Testing
Risk
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.