Move runtimeconfig.template.json stuff to csproj#74124
Merged
MichalStrehovsky merged 3 commits intodotnet:mainfrom Aug 18, 2022
Merged
Move runtimeconfig.template.json stuff to csproj#74124MichalStrehovsky merged 3 commits intodotnet:mainfrom
MichalStrehovsky merged 3 commits intodotnet:mainfrom
Conversation
NativeAOT ignores this and emits a warning. This fails the test build.
|
Tagging subscribers to this area: @dotnet/area-system-resources Issue DetailsNativeAOT ignores this and emits a warning. This fails the test build.
|
Member
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
@dotnet/ilc-contrib could someone have a look? I broke this in #73996 because we now warn instead of silently ignoring. It's probably a good thing. The test was fine because the parts that depended on it also depend on binary serialization so we don't run them... |
jkotas
approved these changes
Aug 18, 2022
Member
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jkotas
reviewed
Aug 18, 2022
...braries/System.Resources.ResourceManager/tests/System.Resources.ResourceManager.Tests.csproj
Outdated
Show resolved
Hide resolved
…sources.ResourceManager.Tests.csproj
Member
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/backport to release/7.0-rc1 |
Contributor
|
Started backporting to release/7.0-rc1: https://github.com/dotnet/runtime/actions/runs/2881976911 |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NativeAOT ignores this and emits a warning. This fails the test build.