Resolve System.Net.Security.Tests.LoggingTest SkipTestException failure#65322
Merged
MihaZupan merged 1 commit intodotnet:mainfrom Feb 15, 2022
Merged
Resolve System.Net.Security.Tests.LoggingTest SkipTestException failure#65322MihaZupan merged 1 commit intodotnet:mainfrom
MihaZupan merged 1 commit intodotnet:mainfrom
Conversation
|
Tagging subscribers to this area: @dotnet/ncl, @vcsjones Issue DetailsFixes #65105 I removed the After this and #65105, there is only one other test (
|
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #65279
I removed the
SkipTestExceptioncheck from theEventSourcetest, letting it delegate to the inner test.After this and #65105, there is only one other test (
EventSource_UnsuccessfulHandshake_LogsStartFailureStop) using an existing test insideRemoteExecutor. But that test doesn't seem like it would ever become flaky / disabled on any OS.