Don't throw from RemoteExecutor on SkipTestExceptions#65105
Don't throw from RemoteExecutor on SkipTestExceptions#65105MihaZupan merged 1 commit intodotnet:mainfrom
Conversation
|
Tagging subscribers to this area: @dotnet/ncl, @vcsjones Issue DetailsFixes #63008 Should be reviewed without looking at whitespace changes.
|
|
Is there any interest in generalized support for communicating a SkipTestException from a RemoteExecutor callback back to the test process? Or is this enough of a one-off scenario that it's not worth the effort? |
I'm not sure @jkoritzinsky. That would be handy in cases when the skip is determined inside of the code that runs inside of the remote. It seems like in most cases we can determine this upfront. In this case, this is caused by this test calling another test that now has SkipTest and this dependency was not obvious. |
|
@wfurt In that case, I think this is an obtuse-enough scenario that we don't need to add support to RemoteExecutor directly. |
Fixes #63008
Should be reviewed without looking at whitespace changes.