Unset FEATURE_EVENTSOURCE_XPLAT in macOS builds

[sywhang]

Fix #48233

@sdmaclea would it be possible for you to run the failing tests on this branch? I don't have an M1 mac at hand to test this.

cc @noahfalk

[ghost]

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Fix #48233

@sdmaclea would it be possible for you to run the tests on this branch? I don't have an M1 mac at hand to test this.

cc @noahfalk

Author:	sywhang
Assignees:	-
Labels:	area-Diagnostics-coreclr
Milestone:	-

[sdmaclea]

Running tests now. It might take a while (I am running gcstress in another terminal).

[sdmaclea]

This fixed most of the issues. There are three failing tracing tests still. Do these need to be disabled for MacOS?.

tracing/tracevalidation/tracelogging/tracelogging/tracelogging.sh

Unhandled exception. System.InvalidOperationException: Reflection failed.
   at Tracing.Tests.Common.TraceConfiguration..ctor(String outputFile, UInt32 circularBufferMB) in /Users/stmaclea/git/runtime/src/tests/tracing/common/TraceC
onfiguration.cs:line 30                                                                                                                                       
   at Tracing.Tests.Common.EventSourceTestSuite.GenerateConfiguration() in /Users/stmaclea/git/runtime/src/tests/tracing/tracevalidation/tracelogging/EventSou
rceTest.cs:line 107                                                            
   at Tracing.Tests.Common.EventSourceTestSuite.RunTests() in /Users/stmaclea/git/runtime/src/tests/tracing/tracevalidation/tracelogging/EventSourceTest.cs:li
ne 53                                                                          
   at Tracing.Tests.TraceLogging.Main(String[] args) in /Users/stmaclea/git/runtime/src/tests/tracing/tracevalidation/tracelogging/TraceLogging.cs:line 123   
/Users/stmaclea/git/runtime/artifacts/tests/coreclr/OSX.arm64.Checked/tracing/tracevalidation/tracelogging/tracelogging/tracelogging.sh: line 395:  9522 Abort trap: 6           $LAUNCHER $ExePath "${CLRTestExecutionArguments[@]}" 

tracing/tracevalidation/rundown/rundown/rundown.sh                                 
                                                                                                                                                              
Unhandled exception. System.TypeInitializationException: The type initializer for 'Tracing.Tests.Common.TraceControl' threw an exception.                     
 ---> System.InvalidOperationException: Reflection failed.                                                                                                    
   at Tracing.Tests.Common.TraceControl..cctor() in /Users/stmaclea/git/runtime/src/tests/tracing/common/TraceControl.cs:line 82                              
   --- End of inner exception stack trace ---                                  
   at Tracing.Tests.TraceValidationRundown.Main(String[] args) in /Users/stmaclea/git/runtime/src/tests/tracing/tracevalidation/rundown/Rundown.cs:line 30    
/Users/stmaclea/git/runtime/artifacts/tests/coreclr/OSX.arm64.Checked/tracing/tracevalidation/rundown/rundown/rundown.sh: line 402:  9525 Abort trap: 6       
    $LAUNCHER $ExePath "${CLRTestExecutionArguments[@]}"              

tracing/tracevalidation/jittingstarted/JittingStarted/JittingStarted.sh

Unhandled exception. System.TypeInitializationException: The type initializer for 'Tracing.Tests.Common.TraceControl' threw an exception.                     
 ---> System.InvalidOperationException: Reflection failed.                                                                                                    
   at Tracing.Tests.Common.TraceControl..cctor() in /Users/stmaclea/git/runtime/src/tests/tracing/common/TraceControl.cs:line 82                              
   --- End of inner exception stack trace ---                                                                                                                 
   at Tracing.Tests.Common.TraceControl.EnableDefault(String outputFile) in /Users/stmaclea/git/runtime/src/tests/tracing/common/TraceControl.cs:line 21      
   at Tracing.Tests.TraceValidationJittingStarted.Main(String[] args) in /Users/stmaclea/git/runtime/src/tests/tracing/tracevalidation/jittingstarted/JittingS
tarted.cs:line 26                 
/Users/stmaclea/git/runtime/artifacts/tests/coreclr/OSX.arm64.Checked/tracing/tracevalidation/jittingstarted/JittingStarted/JittingStarted.sh: line 402:  9518
 Abort trap: 6           $LAUNCHER $ExePath "${CLRTestExecutionArguments[@]}"                                                                                 

[sywhang]

@sdmaclea Those tests were removed from #48053. To give you a little bit more context, those tests depended on a removed internal API that was provided for an internal customer but we moved that customer off that, so all the tests that were testing that feature were removed with it.

[sdmaclea]

Interesting. I saw the failures and wondered if they might be dependent on the flag you set, so I rebuilt the tests. However I didn't delete the originally compiled tests, so I think they must have just ended up in the XUnit Wrappers anyway.

[sdmaclea]

I wonder if this should actually be controlled by the cmake FeatureXplatEventSource property set above. That would keep them consistent.