Remove internal EventPipe API and redundant tests #48053
Merged
sywhang merged 3 commits intodotnet:masterfrom Feb 10, 2021
Merged
Remove internal EventPipe API and redundant tests #48053sywhang merged 3 commits intodotnet:masterfrom
sywhang merged 3 commits intodotnet:masterfrom
Conversation
Contributor
|
CC @lateralusX Glad to see these are no longer needed! |
LakshanF
approved these changes
Feb 9, 2021
Contributor
LakshanF
left a comment
LakshanF
left a comment
There was a problem hiding this comment.
Trimming HelloWorld app works with this change.
josalem
approved these changes
Feb 9, 2021
Contributor
josalem
left a comment
josalem
left a comment
There was a problem hiding this comment.
The libraries test failure doesn't seem related to this patch. LGTM 🚀
| { | ||
| public static class TraceValidationInducedGC | ||
| { | ||
| private static int InducedGCIterations = 10; |
Contributor
There was a problem hiding this comment.
I'm not sure we have an equivalent test for the moder infrastructure. We may want to add one, but that's not part of this PR.
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the internal
EventPipetype which was being used to turn on EventPipe session by an internal profiler team via reflection. They no longer depend on this as they've moved onto using the diagnostics client library.Also this removes a few redundant tests that are using this internal API via reflection to enable tracing tests. I went and checked all of these tests and verified that they are either:
The only test that is not already being tested by another tracing test is JittingStarted test which checks for whether a JittingStarted event is correctly received. I will file a separate issue to track adding this test under tracing/eventpipe.
cc @LakshanF After this PR, you should be able to safely remove the System.Diagnostics.Tracing.EventPipe type from rooted types for the ILTrim.