Only pass the method context when tracking transitions.#47238
Only pass the method context when tracking transitions.#47238jkoritzinsky merged 10 commits intodotnet:masterfrom
Conversation
|
|
…o track transitions
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
|
Hello @jkoritzinsky! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
sandreenko
left a comment
There was a problem hiding this comment.
Jit changes look fine.
…runtime into reverse-pinvoke-helper-opt
|
Why is the last commit needed? These callouts should be limited to JIT only. We would have to introduce a whole new separate R2R image flavor to make that work. It is not something we want to do. |
|
I may have been a little overzealous on adding all the R2R helpers. I’ll go remove the e R2R helpers and just update the JIT helpers on the Crossgen2 side (which is all I really needed to do on that commit) |
This reverts commit 80a4749.
…helpers since they won't be used.
|
Can you take a look at the 2 new commits and let me know what you think? |
|
LGTM otherwise. |
9bb318b to
c1a881d
Compare
Create a new helper instead of modifying an existing one. Only track transitions when we absolutely need to.
Fixes #47223
cc: @dotnet/jit-contrib