Backport #92296 to release/8.0-staging#101627
Merged
carlossanlop merged 1 commit intodotnet:release/8.0-stagingfrom Apr 30, 2024
Merged
Backport #92296 to release/8.0-staging#101627carlossanlop merged 1 commit intodotnet:release/8.0-stagingfrom
carlossanlop merged 1 commit intodotnet:release/8.0-stagingfrom
Conversation
|
Note regarding the |
ghost
added
eduardo-vp
added
area-Infrastructure
and removed
area-System.Reflection.Metadata
new-api-needs-documentation
labels
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
…t#92296) * Build the PGO build legs through the global build job template. * Remove pgoType parameters and plumbing from all jobs and use the -pgoinstrument flag instead of setting the property manually. * Limit subsets to build to limit packages and don't build crossgen2 sfxproj for internal optimization pipelines (we don't use it). * Fix job dependencies now that the non-global jobs don't have PGO type in the name * Change back to the triple-underscore name * Fix Mono artifacts to not have an extra underscore for PGO scenarios. * There's an extra underscore for the CoreCLR artifacts because there's no runtime variant.
eduardo-vp
force-pushed
the
backport-92296-to-release-8.0-staging
branch
from
eea3358 to
d82b8d3
Compare
This was referenced Apr 29, 2024
Closed
eduardo-vp
changed the title
eduardo-vp
changed the title
jkoritzinsky
approved these changes
Apr 29, 2024
Member
jkoritzinsky
left a comment
jkoritzinsky
left a comment
There was a problem hiding this comment.
Verified assets in the official build are right.
jkoritzinsky
added
the
Servicing-consider
jeffschwMSFT
approved these changes
Apr 30, 2024
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. we can treat this as tell mode.
carlossanlop
added
Servicing-approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of the work to transition to the 1ES templates in servicing branches.
Official build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2440254&view=results
cc @jkoritzinsky @agocke @amanasifkhalid